Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify breaking change rules around pagination #1358

Merged
merged 1 commit into from
May 24, 2024

Conversation

jskeet
Copy link
Contributor

@jskeet jskeet commented May 23, 2024

(In particular, that adding pagination breaks client libraries too.)

Fixes #1357.

@jskeet jskeet requested a review from noahdietz May 23, 2024 09:15
@jskeet jskeet requested a review from a team as a code owner May 23, 2024 09:15
@jskeet jskeet requested a review from hrasadi May 23, 2024 09:15
Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit but good change, thanks

@noahdietz noahdietz requested review from itsStrobe and removed request for hrasadi May 23, 2024 19:10
(In particular, that adding pagination breaks client libraries too.)

Fixes aip-dev#1357.
@jskeet jskeet merged commit 3a3f8e1 into aip-dev:master May 24, 2024
2 checks passed
@jskeet jskeet deleted the compatibility branch May 24, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements for backward compatibility
3 participants