fix(AIP-122): remove redundant guidance on user-settable #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guidance on user-settable IDs are already defined in AIP-133. Reiterating the guidance in AIP-122 is redundant and can make maintaining guidance more difficult. Also consolidating terminlogy to "user-specified" IDs, which is how it is currently referred to.
noahdietz
approved these changes
Jun 14, 2023
alin04
reviewed
Jun 29, 2023
alin04
approved these changes
Jun 29, 2023
Hkoma95
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidance on user-settable IDs are already defined in AIP-133.
Reiterating the guidance in AIP-122 is redundant and can make maintaining
guidance more difficult.
Also consolidating terminlogy to "user-specified" IDs, which is
how it is currently referred to.