Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated URL Results in llamaindex-db #12

Open
5 tasks done
Tracked by #146
k-allagbe opened this issue Apr 2, 2024 · 2 comments · Fixed by #13
Open
5 tasks done
Tracked by #146

Duplicated URL Results in llamaindex-db #12

k-allagbe opened this issue Apr 2, 2024 · 2 comments · Fixed by #13
Assignees
Labels
user-visible User visible enhancement or features - must QA

Comments

@k-allagbe
Copy link
Member

k-allagbe commented Apr 2, 2024

Description

When using AI Lab LlamaIndex Search, it is possible to receive multiple search results that reference the same URL. This behavior contrasts with Azure AI Search, where each result corresponds to a unique URL.

Image

Image

Tasks

  • Investigate the cause of duplicate URL results in AI Lab LlamaIndex Search responses: here
  • Explore configuration options or filters in AI Lab LlamaIndex Search to prevent duplicate URLs.
  • Implement a solution to ensure unique URLs in search results, mirroring the behavior seen with Azure AI Search.
  • Add unit tests to verify that search results contain unique URLs.
  • Document the changes and the configuration settings used to achieve the desired result.

Acceptance Criteria

  • No search result set from AI Lab LlamaIndex Search should contain duplicate URLs.
  • The implemented solution should not significantly impact the performance or response time of the search.
  • All unit tests related to search results must pass, confirming the uniqueness of URLs in the results.
@k-allagbe k-allagbe added the user-visible User visible enhancement or features - must QA label Apr 2, 2024
@k-allagbe k-allagbe self-assigned this Apr 3, 2024
@k-allagbe
Copy link
Member Author

Try grouping by URL.

@k-allagbe k-allagbe changed the title Duplicate URL Results with AI Lab LlamaIndex Search Integration Duplicated URL Results with AI Lab LlamaIndex Search in finesse-backend Apr 3, 2024
@k-allagbe k-allagbe transferred this issue from ai-cfia/finesse-backend Apr 28, 2024
@k-allagbe k-allagbe changed the title Duplicated URL Results with AI Lab LlamaIndex Search in finesse-backend Duplicated URL Results with AI Lab LlamaIndex Search in llamaindex-db Apr 28, 2024
k-allagbe added a commit that referenced this issue Apr 28, 2024
k-allagbe added a commit that referenced this issue Apr 28, 2024
k-allagbe added a commit that referenced this issue Apr 29, 2024
@k-allagbe k-allagbe changed the title Duplicated URL Results with AI Lab LlamaIndex Search in llamaindex-db Duplicated URL Results in llamaindex-db Apr 29, 2024
@k-allagbe k-allagbe linked a pull request Apr 29, 2024 that will close this issue
5 tasks
k-allagbe added a commit that referenced this issue Apr 29, 2024
k-allagbe added a commit that referenced this issue Apr 29, 2024
@k-allagbe k-allagbe moved this from In Progress to In Review in Finesse Apr 29, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Finesse Apr 29, 2024
@k-allagbe
Copy link
Member Author

Reopening.

"What are acceptable methods for disposing of food?"

image

@k-allagbe k-allagbe reopened this May 8, 2024
@k-allagbe k-allagbe moved this from Done to Todo in Finesse May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user-visible User visible enhancement or features - must QA
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

2 participants