Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect tor port even in developer mode #132

Closed
wants to merge 38 commits into from
Closed

Conversation

burdges
Copy link
Contributor

@burdges burdges commented Oct 24, 2014

Detect tor port even in developer mode so that PANDA can run properly under TBB. There was an issue because PANDA runs over tor even in developer mode, but TBB uses port 9150 rather than the default tor port 9050.

burdges and others added 14 commits January 30, 2014 11:01
… under TBB. There was an issue because PANDA runs over tor even in developer mode, but TBB uses port 9150 rather than the default tor port 9050.

Allow tor to be used by PANDA when running in developer mode

Oops
This change causes error messages from the ratchet code to be surfaces
to the user in the contact log. This is to help debug agl#124.
When installing on Ubuntu 14.04, Go 1.3 will need to be installed from
source since Ubuntu's is too old now. (Noted in agl#123.)

See https://golang.org/doc/go1.3#cgo for details of the changes.
… under TBB. There was an issue because PANDA runs over tor even in developer mode, but TBB uses port 9150 rather than the default tor port 9050.

Allow tor to be used by PANDA when running in developer mode

Oops
@burdges
Copy link
Contributor Author

burdges commented Oct 24, 2014

Apologies for the wonky commit history, not sure what I pulled from where to get those spurious reverts which needed to be reverted.

…ntacts branch. Renamed contactsSorted to lower case for consistency.
…eful for various planned features, including contat invitations, messages with multiple recipants, and editable notes fields for contacts.

In fact, I considered moving inputTextBlock to cli-inout.go, but it wouldn't save many imports in cli.go to do so.
Does not resolve the existence of DELIVERY_SIGNATURE_INVALID messages in agl#134
@agl
Copy link
Owner

agl commented Nov 2, 2014

I'm afraid that I can't see which commit is being suggested here!

@burdges
Copy link
Contributor Author

burdges commented Nov 2, 2014

Appears you got the most important one. burdges@5e4110d is probably superfluous now.

These are minor bug fixes :
#109 - burdges@777b5a5
#125 - burdges@53b50d9

Oh, the original patch to support PANDA on port 9150 in developer mode is either one of burdges@552c877 or burdges@ab285b0 due to the unfortunate revert chaos.

These are minor refactoring patches that I felt were worth submitting now instead of with larger change set :
burdges@cb2a82c
burdges@63bd1c3
burdges@2e9e3d8

…ating messages to specific recipiants and makes teh code more redable.
… under TBB. There was an issue because PANDA runs over tor even in developer mode, but TBB uses port 9150 rather than the default tor port 9050.

Allow tor to be used by PANDA when running in developer mode

Oops
@burdges burdges closed this Nov 3, 2014
@burdges
Copy link
Contributor Author

burdges commented Nov 3, 2014

I'll try to figure out how to fix this commit history

@burdges
Copy link
Contributor Author

burdges commented Nov 3, 2014

Improved version here : #136

There are still a few hick ups there, but I don't want to tempt the rebase gods wrath too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants