Reliable Function Agent #927
Draft
+1,616
−371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davorrunje
reviewed
Feb 12, 2025
| @@ -3003,7 +3005,7 @@ async def _a_wrapped_func(*args, **kwargs): | |||
| retval = await func(*args, **kwargs, **inject_params) | |||
| if logging_enabled(): | |||
| log_function_use(self, func, kwargs, retval) | |||
| return serialize_to_str(retval) | |||
| return retval | |||
There was a problem hiding this comment.
We should revert this and find a way to serialise Swarm result when needed.
| from inspect import Parameter, Signature, markcoroutinefunction, signature | ||
| from typing import Annotated, Any, Callable, Dict, List, Optional, Tuple, Union | ||
|
|
||
| from openai import BaseModel |
There was a problem hiding this comment.
Suggested change
| from openai import BaseModel | |
| from pydantic import BaseModel |
|
|
||
| # This class relies heavily on using context_variables to store state as it is working. | ||
| # It uses the key {name}-ReliableFunctionContext as the location it writes to | ||
| __all__ = ["ReliableFunctionAgent"] |
There was a problem hiding this comment.
move up, just below the imports
| def __init__( | ||
| self, | ||
| name: str, | ||
| runner_llm_config: dict, |
There was a problem hiding this comment.
Suggested change
| runner_llm_config: dict, | |
| runner_llm_config: dict[str, Any], |
| validator_llm_config: dict, | ||
| agent_system_message: str, | ||
| validator_system_message: str, | ||
| func_or_tool: Union[Callable, Tool], |
There was a problem hiding this comment.
Suggested change
| func_or_tool: Union[Callable, Tool], | |
| func_or_tool: Union[Callable[..., Any], Tool], |
| validator_system_message: str, | ||
| func_or_tool: Union[Callable, Tool], | ||
| max_rounds: int = 10, | ||
| **kwargs, |
There was a problem hiding this comment.
Suggested change
| **kwargs, | |
| **kwargs: Any, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is NOT ready for review yet!
Why are these changes needed?
Related issue number
Checks