Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support openai o1 model with custom model name. #552

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mai0313
Copy link
Collaborator

@Mai0313 Mai0313 commented Jan 20, 2025

Why are these changes needed?

For my company, MediaTek, we use custom name called aide-o1-preview and aide-o1-mini for o1 and o1-mini via Azure Service.
I know using "o1-" in model_name to detect o1 model can be bad, but as far as I know, only OpenAI o1 model contains o1- and it perfectly solve my problem.

I am open to discuss more about how to fix it better.

Related issue number

#347

Checks

@Mai0313 Mai0313 requested a review from sonichi January 20, 2025 08:27
@davorrunje davorrunje self-assigned this Jan 20, 2025
@davorrunje
Copy link
Collaborator

davorrunje commented Jan 20, 2025

@Mai0313 I understand the need to fix this but I would suggest a slightly different approach. For api_type=="azure", we could add an additional field oai_model_name that could be set to the original OAI name. That would be easier to scale and maintain.

We plan to release 0.7.2 on Wednesday so we have enough time to make this change for the next release.

@Mai0313
Copy link
Collaborator Author

Mai0313 commented Feb 3, 2025

@Mai0313 I understand the need to fix this but I would suggest a slightly different approach. For api_type=="azure", we could add an additional field oai_model_name that could be set to the original OAI name. That would be easier to scale and maintain.

We plan to release 0.7.2 on Wednesday so we have enough time to make this change for the next release.

OK, it sounds good

@sonichi
Copy link
Collaborator

sonichi commented Feb 9, 2025

@Mai0313 I understand the need to fix this but I would suggest a slightly different approach. For api_type=="azure", we could add an additional field oai_model_name that could be set to the original OAI name. That would be easier to scale and maintain.
We plan to release 0.7.2 on Wednesday so we have enough time to make this change for the next release.

OK, it sounds good

@Mai0313 @davorrunje can we get clarity about who will make the proposed change and the timeline? I appreciate that.
@Mai0313 is it a change that you are comfortable to make?

@Hk669
Copy link
Collaborator

Hk669 commented Feb 10, 2025

hey @Mai0313, were you able to get this working as @davorrunje suggested a different approach? if not, let us know, if you are working on this, else should i take this up. thanks

cc - @marklysze @sonichi

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants