-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support openai o1 model with custom model name. #552
base: main
Are you sure you want to change the base?
Conversation
@Mai0313 I understand the need to fix this but I would suggest a slightly different approach. For We plan to release 0.7.2 on Wednesday so we have enough time to make this change for the next release. |
OK, it sounds good |
@Mai0313 @davorrunje can we get clarity about who will make the proposed change and the timeline? I appreciate that. |
hey @Mai0313, were you able to get this working as @davorrunje suggested a different approach? if not, let us know, if you are working on this, else should i take this up. thanks cc - @marklysze @sonichi |
|
Why are these changes needed?
For my company, MediaTek, we use custom name called
aide-o1-preview
andaide-o1-mini
foro1
ando1-mini
viaAzure Service
.I know using
"o1-" in model_name
to detect o1 model can be bad, but as far as I know, only OpenAI o1 model containso1-
and it perfectly solve my problem.I am open to discuss more about how to fix it better.
Related issue number
#347
Checks