Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete completion #1223

Merged
merged 16 commits into from
Mar 6, 2025
Merged

Remove obsolete completion #1223

merged 16 commits into from
Mar 6, 2025

Conversation

kumaranvpl
Copy link
Collaborator

@kumaranvpl kumaranvpl commented Mar 4, 2025

Why are these changes needed?

Related issue number

Closes #1224, #1226

Checks

Copy link
Collaborator

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some dependencies in the repo:

https://github.com/ag2ai/ag2/blob/main/notebook/oai_completion.ipynb
https://github.com/ag2ai/ag2/blob/main/notebook/oai_chatgpt_gpt4.ipynb

Can we update the notebooks' installation sections? For example,
pip install "autogen[blendsearch]<0.2" -> pip install "pyautogen[blendsearch]<0.2"

Also provide a pointer to a latest branch that contain the working code for them, in case users need to refer to the source code.

@kumaranvpl
Copy link
Collaborator Author

@sonichi I have restricted the version below 0.2 and added a note with a link pointing to the tag in repository. Please review it when you can.

sonichi
sonichi previously requested changes Mar 5, 2025
@kumaranvpl kumaranvpl requested a review from sonichi March 5, 2025 07:00
@kumaranvpl
Copy link
Collaborator Author

@sonichi Changes done. Review when you are free please.

@davorrunje davorrunje enabled auto-merge March 6, 2025 07:28
@davorrunje davorrunje dismissed sonichi’s stale review March 6, 2025 09:35

Done as requested.

@davorrunje davorrunje added this pull request to the merge queue Mar 6, 2025
Merged via the queue into main with commit d5263b3 Mar 6, 2025
17 checks passed
@davorrunje davorrunje deleted the remove-obsolete-completion branch March 6, 2025 09:42
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ There is a different number of reports uploaded between BASE (40bcd0f) and HEAD (e19ed69). Click for more details.

HEAD has 1268 uploads less than BASE
Flag BASE (40bcd0f) HEAD (e19ed69)
3.13 85 0
core-without-llm 14 1
ubuntu-latest 146 1
3.10 96 0
commsagent-discord 9 0
optional-deps 141 0
3.9 83 0
macos-latest 104 0
3.11 64 1
browser-use 7 0
commsagent-slack 9 0
3.12 36 0
commsagent-telegram 9 0
windows-latest 114 0
crawl4ai 13 0
docs 6 0
graph-rag-falkor-db 6 0
interop 13 0
interop-crewai 9 0
interop-langchain 9 0
interop-pydantic-ai 9 0
retrievechat 15 0
retrievechat-mongodb 10 0
jupyter-executor 9 0
retrievechat-pgvector 10 0
twilio 9 0
retrievechat-qdrant 14 0
websockets 9 0
bedrock 15 0
agent-eval 1 0
gpt-assistant-agent 3 0
anthropic 16 0
cerebras 15 0
retrievechat-couchbase 3 0
cohere 15 0
llama-index-agent 3 0
lmm 4 0
gemini 15 0
groq 14 0
mistral 14 0
ollama 15 0
teachable 4 0
swarm 14 0
long-context 3 0
together 14 0
websurfer 15 0
integration 12 0
core-llm 9 0
falkordb 2 0
openai-realtime 1 0
gemini-realtime 1 0
autobuild 1 0
neo4j 2 0
deepseek 1 0
openai 1 0
Files with missing lines Coverage Δ
autogen/__init__.py 100.00% <ø> (ø)
autogen/code_utils.py 75.00% <100.00%> (+5.99%) ⬆️
autogen/math_utils.py 7.55% <ø> (-47.45%) ⬇️
autogen/oai/__init__.py 100.00% <ø> (ø)

... and 68 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove obsolete completion.py
3 participants