Refactor des tests unitaires avec PHPUnit #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakovicz
approved these changes
Mar 2, 2025
Mopolo
force-pushed
the
refactor-unit-tests-with-phpunit
branch
from
a651454 to
51ab36f
Compare
Mopolo
force-pushed
the
refactor-unit-tests-with-phpunit
branch
from
51ab36f to
eeb30ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
J'en parle depuis un moment et j'ai enfin pris le temps de faire la conversion des tests.
PHPUnit est supporté jusqu'à la version 8 donc on a le temps de passer aux suivantes (la v10 a besoin de PHP 8.1).
Pourquoi ce changement ?
À long terme, et avec tout ce qu'on fait en ce moment sur les majs de SF et PHP je pense que ce sera plus maintenable. Et ça rend la contribution plus accessible (à mon avis).