Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlexCharge: Changing response interpretation for Async txns #5424

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

Heavyblade
Copy link
Collaborator

Summary

This changes the way that flex charge interprets a 'challenge' response depending on the 'async' gsf

Tests

Unit Tests

Finished in 44.57413 seconds.
6212 tests, 81323 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote Tests

Finished in 83.457291 seconds.
21 tests, 63 assertions, 1 failures, 0 errors, 0 pendings, 2 omissions, 0 notifications
94.7368% passed

Rubocop

808 files inspected, no offenses detected

Summary
-------------------------

This changes the way that flex charge interprests a 'challenge'
response depending on the 'async' gsf

Unit Tests
----------------
Finished in 44.57413 seconds.
6212 tests, 81323 assertions, 0 failures, 0 errors, 0 pendings,
0 omissions, 0 notifications
100% passed

Remote Tests
----------------
Finished in 83.457291 seconds.
21 tests, 63 assertions, 1 failures, 0 errors, 0 pendings,
2 omissions, 0 notifications
94.7368% passed

Rubocop
----------------
808 files inspected, no offenses detected
@Heavyblade Heavyblade requested a review from naashton March 7, 2025 16:23
Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks pretty straight forward.

@Heavyblade Heavyblade merged commit 68eeb93 into master Mar 10, 2025
5 checks passed
@Heavyblade Heavyblade deleted the flex_charge_change_sync_response_intepretation branch March 10, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants