FlexCharge: Changing response interpretation for Async txns #5424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ------------------------- This changes the way that flex charge interprests a 'challenge' response depending on the 'async' gsf Unit Tests ---------------- Finished in 44.57413 seconds. 6212 tests, 81323 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote Tests ---------------- Finished in 83.457291 seconds. 21 tests, 63 assertions, 1 failures, 0 errors, 0 pendings, 2 omissions, 0 notifications 94.7368% passed Rubocop ---------------- 808 files inspected, no offenses detected
naashton
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changes the way that flex charge interprets a 'challenge' response depending on the 'async' gsf
Tests
Unit Tests
Finished in 44.57413 seconds.
6212 tests, 81323 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote Tests
Finished in 83.457291 seconds.
21 tests, 63 assertions, 1 failures, 0 errors, 0 pendings, 2 omissions, 0 notifications
94.7368% passed
Rubocop
808 files inspected, no offenses detected