-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plexo: Add transaction Sync #5416
Conversation
a575cf6
to
c19eba4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @javierpedrozaing , left some comments on code correctness
a5c8fbc
to
bb2e80c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for fixing up the test card exp date. Can you also add a changelog for this?
bb2e80c
to
8c6f071
Compare
Description ------------------------- [SER-1592](https://spreedly.atlassian.net/browse/SER-1592) This commit adds transaction sync for Plexo gateway, includes a small code refactoring on the commit method and updates the expiration year in the remote test Unit test ------------------------- 26 tests, 144 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote test ------------------------- 34 tests, 70 assertions, 1 failures, 0 errors, 0 pendings, 3 omissions, 0 notifications 96.7742% passed Rubocop ------------------------- 808 files inspected, no offenses detected
8c6f071
to
e4ad197
Compare
Hey @naashton changelog updated, thanks |
Description
SER-1592
This commit adds transaction sync for Plexo gateway,
includes a small code refactoring on the commit method
and updates the expiration year in the remote test.
Unit test
26 tests, 144 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Remote test
33 tests, 65 assertions, 3 failures, 0 errors, 0 pendings, 3 omissions, 0 notifications 90% passed
Rubocop
808 files inspected, no offenses detected