Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plexo: Add transaction Sync #5416

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Conversation

javierpedrozaing
Copy link
Collaborator

Description

SER-1592

This commit adds transaction sync for Plexo gateway,
includes a small code refactoring on the commit method
and updates the expiration year in the remote test.

Unit test

26 tests, 144 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

Remote test

33 tests, 65 assertions, 3 failures, 0 errors, 0 pendings, 3 omissions, 0 notifications 90% passed

Rubocop

808 files inspected, no offenses detected

@javierpedrozaing javierpedrozaing marked this pull request as ready for review February 26, 2025 17:30
@javierpedrozaing javierpedrozaing force-pushed the SER-1592-Plexo-add_transaction_sync branch 2 times, most recently from a575cf6 to c19eba4 Compare February 28, 2025 20:18
Copy link
Collaborator

@Heavyblade Heavyblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @javierpedrozaing , left some comments on code correctness

@javierpedrozaing javierpedrozaing force-pushed the SER-1592-Plexo-add_transaction_sync branch 2 times, most recently from a5c8fbc to bb2e80c Compare March 5, 2025 14:59
Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing up the test card exp date. Can you also add a changelog for this?

@javierpedrozaing javierpedrozaing force-pushed the SER-1592-Plexo-add_transaction_sync branch from bb2e80c to 8c6f071 Compare March 10, 2025 14:00
Description
-------------------------
[SER-1592](https://spreedly.atlassian.net/browse/SER-1592)

This commit adds transaction sync for Plexo gateway,
includes a small code refactoring on the commit method and
updates the expiration year in the remote test

Unit test
-------------------------
26 tests, 144 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote test
-------------------------
34 tests, 70 assertions, 1 failures, 0 errors, 0 pendings, 3 omissions, 0 notifications
96.7742% passed

Rubocop
-------------------------
808 files inspected, no offenses detected
@javierpedrozaing javierpedrozaing force-pushed the SER-1592-Plexo-add_transaction_sync branch from 8c6f071 to e4ad197 Compare March 10, 2025 14:02
@javierpedrozaing
Copy link
Collaborator Author

Hey @naashton changelog updated, thanks

@naashton naashton merged commit 8fed1ab into master Mar 12, 2025
5 checks passed
@naashton naashton deleted the SER-1592-Plexo-add_transaction_sync branch March 12, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants