Plexo: Add transaction Sync #5416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierpedrozaing
force-pushed
the
SER-1592-Plexo-add_transaction_sync
branch
2 times, most recently
from
a575cf6 to
c19eba4
Compare
Heavyblade
reviewed
Mar 3, 2025
There was a problem hiding this comment.
Looks good @javierpedrozaing , left some comments on code correctness
javierpedrozaing
force-pushed
the
SER-1592-Plexo-add_transaction_sync
branch
2 times, most recently
from
a5c8fbc to
bb2e80c
Compare
naashton
approved these changes
Mar 7, 2025
javierpedrozaing
force-pushed
the
SER-1592-Plexo-add_transaction_sync
branch
from
bb2e80c to
8c6f071
Compare
Description ------------------------- [SER-1592](https://spreedly.atlassian.net/browse/SER-1592) This commit adds transaction sync for Plexo gateway, includes a small code refactoring on the commit method and updates the expiration year in the remote test Unit test ------------------------- 26 tests, 144 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote test ------------------------- 34 tests, 70 assertions, 1 failures, 0 errors, 0 pendings, 3 omissions, 0 notifications 96.7742% passed Rubocop ------------------------- 808 files inspected, no offenses detected
javierpedrozaing
force-pushed
the
SER-1592-Plexo-add_transaction_sync
branch
from
8c6f071 to
e4ad197
Compare
|
Hey @naashton changelog updated, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SER-1592
This commit adds transaction sync for Plexo gateway,
includes a small code refactoring on the commit method
and updates the expiration year in the remote test.
Unit test
26 tests, 144 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Remote test
33 tests, 65 assertions, 3 failures, 0 errors, 0 pendings, 3 omissions, 0 notifications 90% passed
Rubocop
808 files inspected, no offenses detected