Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abseil LTS 20210324, Patch 1 #943

Merged
merged 4 commits into from
Apr 20, 2021
Merged

Abseil LTS 20210324, Patch 1 #943

merged 4 commits into from
Apr 20, 2021

Conversation

derekmauro
Copy link
Member

No description provided.

cblichmann and others added 3 commits April 20, 2021 11:28
@cblichmann @derekmauro
Add missing add_subdirectory() call for "cleanup" (abseil#925)
7fce38a 
Since `absl::Cleanup` is now public, it should also be included
in the `absl/CMakeLists.txt` file.

Signed-off-by: Christian Blichmann <[email protected]>
@derekmauro
Correctly install pkgconfig files under CMAKE_INSTALL_LIBDIR
2b53f3f 
Fixes abseil#931

PiperOrigin-RevId: 366816645
@derekmauro
AbseilConfigureCopts.cmake: fix AppleClang detection
1fed00d 
restore use of MATCHES in comparison with "Clang"; this was lost in:

commit 22771d4
  ...
  24e1f5f72756046f5265abf618e951c341f09b8d by Derek Mauro <[email protected]>:

  Fixes failing CMake string comparisons
  https://cmake.org/cmake/help/latest/policy/CMP0054.html

fixes:
CMake Warning at absl/copts/AbseilConfigureCopts.cmake:61 (message):
  Unknown compiler:
  /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++.
  Building with no default flags

Fixes abseil#930

PiperOrigin-RevId: 366879337
@google-cla
Copy link

google-cla bot commented Apr 20, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Apr 20, 2021
@google-cla
Copy link

google-cla bot commented Apr 20, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@derekmauro derekmauro merged commit e1d388e into abseil:lts_2021_03_24 Apr 20, 2021
@derekmauro derekmauro deleted the lts_2021_03_24_patch1 branch April 20, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derekmauro @cblichmann