Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DivBlock のパースの不具合を修正 #138

Merged
merged 2 commits into from
Jun 21, 2024
Merged

DivBlock のパースの不具合を修正 #138

merged 2 commits into from
Jun 21, 2024

Conversation

noya2ruler
Copy link
Collaborator

close #137

DivBlock が閉じなかったときの処理が間違っていた。

  • move_next_line はするべきではない(すでに eof に達しているはず)
  • 実際には閉じたとしても、閉じていないとして処理してしまっていた

DivBlock が閉じて while を抜ける時にscopes.empty() == true となるように実装を修正した。

@abap34 abap34 self-requested a review June 21, 2024 05:07
Copy link
Owner

@abap34 abap34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 👍

@abap34 abap34 merged commit 3100fc5 into main Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

不完全な DivBlock のパースで Segmentation Fault する
2 participants