-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve "(de)serialization of preprocessing" #616
base: main
Are you sure you want to change the base?
Resolve "(de)serialization of preprocessing" #616
Conversation
Made a PR to a16z/arkworks-algebra for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Now that I've merged your PR to https://github.com/a16z/arkworks-algebra/ I think we need to run cargo update
here
Modify high-level Jolt SDK to allow preprocessing to be de/serialized and performed separately for prover/verifier
This PR implements the changes to the high-level Jolt API described in #585. The main features are as follows:
CanonicalSerialize
andCanonicalDeserialize
for preprocessing, along with helper functions to save/read it in the target directoryA couple of other points to mention:
CanonicalSerialize
andCanonicalDeserialize
on the preprocessing involved making a PR toark-algebra
to provide implementations of these for signed integers. That work will probably need to be merged into https://github.com/a16z/arkworks-algebra/ before this can be merged. I'll go ahead and make a PR for that. The arkworks PR is here: ImplementCanonicalSerialize
andCanonicalDeserialize
for signed integers arkworks-rs/algebra#953Closes #585