Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hunter job payouts not being applied #1688

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Conversation

DersWasTaken
Copy link
Contributor

Entities that die after being hit due to non-player means such as fire aspect, cactus, or magma blocks, don't give player payouts.

To fix this, a cache entityLastDamager was created which tracks the last damager of the entity, and is used to set the killer of the entity (Entity#setKiller) when the last damage cause on entity death was not another entity.

@DersWasTaken
Copy link
Contributor Author

I didn't add a config option for this because I don't think its necessary. There isn't a way to exploit this that doesn't require you to hit the mob atleast once, and the minimum damage amount config option still applies. This can be added if needed to get the merge approved.

@Zrips Zrips merged commit ddc9000 into Zrips:master Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants