Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bucketing Entities Action #1583

Merged
merged 6 commits into from
Aug 30, 2023
Merged

Bucketing Entities Action #1583

merged 6 commits into from
Aug 30, 2023

Conversation

FireML
Copy link
Contributor

@FireML FireML commented Apr 1, 2023

Adds a new action type called "Bucket", which will payout when an aquatic entity is bucketed.

@FireML
Copy link
Contributor Author

FireML commented May 19, 2023

Any information on this @Zrips? It's been a while since I made it

@FireML FireML closed this Jun 16, 2023
@FireML FireML reopened this Jul 28, 2023
@Zrips
Copy link
Owner

Zrips commented Aug 29, 2023

Can't merge this one directly as its not properly version dependent. Bucketing entities is relatively new event, it needs to be moved into its correct separate event listener which gets enabled past certain minecraft version.

@FireML
Copy link
Contributor Author

FireML commented Aug 29, 2023

I see. I'll sort that out soonish

FireML added 2 commits August 30, 2023 03:47
All tested and working on Spigot 1.16.5 and 1.20.1.
@FireML
Copy link
Contributor Author

FireML commented Aug 30, 2023

Sorted

@Zrips Zrips merged commit 5667544 into Zrips:master Aug 30, 2023
@FireML FireML deleted the bucket-entity-action branch September 4, 2023 13:25
@FireML FireML restored the bucket-entity-action branch September 4, 2023 19:32
@FireML FireML deleted the bucket-entity-action branch September 9, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants