Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fishing, and you get warned by
MCMMO
you don't get paid.This is because
isExploitingFishing
returns true when a player is warned.It should be
isFishingTooOfter
as it returns true when they should not catch a fish.This is seen in the
MCMMO
plugin atPlayerListener.java
I think it makes more sense that players should still get paid for catching the fish. At the moment players do not get paid for catching the fish.