Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jobs fishing listener MCMMO fix #1520

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Jobs fishing listener MCMMO fix #1520

merged 1 commit into from
Nov 14, 2022

Conversation

Smudgge
Copy link
Contributor

@Smudgge Smudgge commented Nov 4, 2022

When fishing, and you get warned by MCMMO you don't get paid.

This is because isExploitingFishing returns true when a player is warned.

It should be isFishingTooOfter as it returns true when they should not catch a fish.

This is seen in the MCMMO plugin at PlayerListener.java

//Spam Fishing
if(event.getState() == PlayerFishEvent.State.CAUGHT_FISH && fishingManager.isFishingTooOften()) {
   event.setExpToDrop(0);

  if(caught instanceof Item caughtItem) {
    caughtItem.remove();
  }

  return;
}

I think it makes more sense that players should still get paid for catching the fish. At the moment players do not get paid for catching the fish.

`isExploitingFishing` returns true when a player is warned.

`isFishingTooOfter` returns true when they should not catch a fish.

I think it makes more sence that thye should still get paid for catching the fish.
@Zrips Zrips merged commit c4ecee7 into Zrips:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants