ExploreRegion: Fix encoding X and Z

[jippi]

Use a long to store the two ints (x is upper and z is lower) - this is guaranteed to work with any world map size out there.

It also properly handle negative values that the old implementation sometimes did not properly manage.

This might use slightly more RAM, but should provide support for actual infinite/huge map sizes

---

Context

Negative coordinates in both X and Z do not encode properly back and forth between getPlace() and getChunkX() + getChunkZ()

Steps to reproduce

• join server
• join explorer
• walk a couple of chunks in a negative X and/or Z chunk position
• /stop the server
• join the server again
• walk the same couple of chunks
• double entries from the same user in explorerData (and XP/money are given each time)

it only bugs out if I do a /stop - and it's extremely reproducible on my server.

Doing /jobs reload and other commands do not affect it, it seems to be a storage/read back on start-up issue.

As seen from my debugging branch the X/Z values do not always encode back and forth correctly, causing bad data (and duplicated rows) in the DB

1.18-test_1       | [19:52:17 WARN]: [Jobs] ADDING chunk value -92/13
1.18-test_1       | [19:52:17 WARN]: [Jobs] Returning would be -68/13

the X and Z coords matches F3 in-game, but the reversing does not 🙂
but its true for both x and z values, once the player are in negative territory, they skew

SQLite output (same issue with MySQL)

sqlite> select * from exploreData order by chunkZ,chunkX;
122|world|-68|13|1|1 
124|world|-68|13|1|1 <- duplicate of previous row
121|world|-68|14|1|1
125|world|-68|14|1|1 <- duplicate of previous row

Version info

[Fri, 7. Jan 2022 16:25:25 CET INFO] Jobs: 5.0.1.0 SqLite
[Fri, 7. Jan 2022 16:25:25 CET INFO] CMILib: 1.1.0.6
[Fri, 7. Jan 2022 16:25:25 CET INFO] Server: Paper(137) 1.18.1-R0.1-SNAPSHOT
[Fri, 7. Jan 2022 16:25:25 CET INFO] Economy: Essentials Economy Vault: 1.7.3-b131

Plugins

Plugins (48): AdvancedAFK, ArmoredElytra, AuctionHouse, BungeeTabListPlus, ChestShop, ChestShopNotifier, ChestSort, CMILib, CoreProtect, DiscordSRV, DiscordSRV-Staff-Chat, dynmap, Essentials, FastChunkPregenerator, floodgate, Graves, HolographicDisplays, HoloPlots, InvSeePlusPlus, Jobs, Lands, LeaderHeadsRevamped, LevelledMobs, LuckPerms, MoreMobHeads, Multiverse-Core, Multiverse-Inventories, Multiverse-Portals, MyCommand, NetworkManager, PlaceholderAPI, PlaceholderSIGN, Plot2Dynmap, PlotSquared, ProtocolLib, ServerlistMOTD*, ShowItem, SimplePortals, spark, SurvivalInvisiframes, UnifiedMetrics, Vault, VentureChat, ViaBackwards, ViaVersion, Votifier, VotingPlugin, WorldEdit

Signed-off-by: Christian Winther [email protected]