Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enchantment Fixes #1279

Merged
merged 4 commits into from
Oct 26, 2021
Merged

Enchantment Fixes #1279

merged 4 commits into from
Oct 26, 2021

Conversation

BeepoWuff
Copy link
Contributor

Supersedes #1262

Fixes the following enchanting issues:

  1. Enchantments with underscores not matching in direct string comparisons for job payment
  2. Being paid for existing enchantments on an item when adding new ones with a book on an anvil
  3. Quest enchantment objective detection being overly specific and case sensitive (unlike job tasks)

@Zrips Zrips merged commit 3f9206b into Zrips:master Oct 26, 2021
@BeepoWuff BeepoWuff deleted the enchantment-fixes branch December 26, 2021 06:50
@BeepoWuff BeepoWuff restored the enchantment-fixes branch December 26, 2021 06:50
@BeepoWuff BeepoWuff deleted the enchantment-fixes branch December 26, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BeepoWuff @Zrips