Fix encoding of nested Scilla maps #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHinshelwood
requested review from
bzawisto,
86667,
DrZoltanFazekas and
shawn-zil
DrZoltanFazekas
previously approved these changes
Mar 10, 2025
|
Bencher Report| Branch | jh-scilla-state-nested-maps |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| full-blocks-erc20-transfers/full-blocks-erc20-transfers | 📈 view plot 🚷 view threshold | 1,055.60 ms(-1.43%)Baseline: 1,070.95 ms | 1,388.33 ms (76.03%) |
| full-blocks-evm-transfers/full-blocks-evm-transfers | 📈 view plot 🚷 view threshold | 443.93 ms(+9.52%)Baseline: 405.33 ms | 490.74 ms (90.46%) |
| full-blocks-zil-transfers/full-blocks-zil-transfers | 📈 view plot 🚷 view threshold | 3,373.00 ms(-16.17%)Baseline: 4,023.54 ms | 5,575.47 ms (60.50%) |
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 10.30 ms(+3.21%)Baseline: 9.98 ms | 10.72 ms (96.06%) |
When returning a nested map to the Scilla interpreter, we need to omit the requested prefix map keys in the response. Also we now decode the keys as strings, rather than JSON strings. Co-authored-by: Bartosz Zawistowski <[email protected]>
JamesHinshelwood
force-pushed
the
jh-scilla-state-nested-maps
branch
from
e8cb7a3 to
4d4afc6
Compare
shawn-zil
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When returning a nested map to the Scilla interpreter, we need to omit the requested prefix map keys in the response. Also we now decode the keys as strings, rather than JSON strings.