fix: Incorrect value is transferred to zero account as the gas fee #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rect-value-is-transferred-to-zero-account-as-the-gas-fees
|
Bencher Report| Branch | 2441-incorrect-value-is-transferred-to-zero-account-as-the-gas-fees |
| Testbed | self-hosted |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|
| process-empty/process-empty | Latency milliseconds (ms) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 11.62 ms(+14.98%)Baseline: 10.10 ms | 11.18 ms (103.92%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| full-blocks-erc20-transfers/full-blocks-erc20-transfers | 📈 view plot 🚷 view threshold | 1,264.60 ms(+17.66%)Baseline: 1,074.79 ms | 1,370.83 ms (92.25%) |
| full-blocks-evm-transfers/full-blocks-evm-transfers | 📈 view plot 🚷 view threshold | 443.81 ms(+7.68%)Baseline: 412.17 ms | 502.77 ms (88.27%) |
| full-blocks-zil-transfers/full-blocks-zil-transfers | 📈 view plot 🚷 view threshold | 4,126.70 ms(+4.23%)Baseline: 3,959.16 ms | 5,341.43 ms (77.26%) |
| process-empty/process-empty | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 11.62 ms(+14.98%)Baseline: 10.10 ms | 11.18 ms (103.92%) |
JamesHinshelwood
requested changes
Mar 6, 2025
…rect-value-is-transferred-to-zero-account-as-the-gas-fees
…rect-value-is-transferred-to-zero-account-as-the-gas-fees
JamesHinshelwood
requested changes
Mar 10, 2025
Co-authored-by: James Hinshelwood <[email protected]>
…the-gas-fees' of https://github.com/Zilliqa/zq2 into 2441-incorrect-value-is-transferred-to-zero-account-as-the-gas-fees
…rect-value-is-transferred-to-zero-account-as-the-gas-fees
…account-as-the-gas-fees
…rect-value-is-transferred-to-zero-account-as-the-gas-fees
…the-gas-fees' of https://github.com/Zilliqa/zq2 into 2441-incorrect-value-is-transferred-to-zero-account-as-the-gas-fees
JamesHinshelwood
previously approved these changes
Mar 17, 2025
JamesHinshelwood
approved these changes
Mar 17, 2025
saeed-zil
deleted the
2441-incorrect-value-is-transferred-to-zero-account-as-the-gas-fees
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not sure if
zilliqa/tests/it/main.rsis the best place to factor outget_stakersandget_reward_addressfunctions. There are used in both consensus.rs and staking.rs