Api #7097
Merged
Api #7097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
NikolajBjorner
commented
Jan 24, 2024
NikolajBjorner
commented
Jan 24, 2024
NikolajBjorner
commented
Jan 24, 2024
|
|
||
| class ul_pair { | ||
| class lar_term; // forward definition | ||
| class column { | ||
| u_dependency* m_lower_bound_witness = nullptr; | ||
| u_dependency* m_upper_bound_witness = nullptr; | ||
| bool m_associated_with_row = false; |
There was a problem hiding this comment.
currently, m_associated_with_row is set in tandem with m_term, so redundant?
NikolajBjorner
commented
Jan 24, 2024
src/math/lp/column.h
Outdated
| // TODO - seems more straight-forward to just expose ul_pair as a struct with direct access to attributes. | ||
|
|
||
| lar_term* term() const { return m_term; } | ||
| lar_term*& term() { return m_term; } // for setting m_term |
There was a problem hiding this comment.
you actually use this?
There was a problem hiding this comment.
No, it is not used. Removed now.
NikolajBjorner
commented
Jan 24, 2024
| if (col.term() != nullptr) { | ||
| if (s.m_need_register_terms) | ||
| s.deregister_normalized_term(*col.term()); | ||
| delete col.term(); |
There was a problem hiding this comment.
or delete s.m_terms.back();
There was a problem hiding this comment.
we have col == s.m_terms.back() here already. I am not sure what we gain by using "delete s.m_terms.back()".
Signed-off-by: Lev Nachmanson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.