Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added additionalGetVars for TYPO3_branch < 9.5 #444

Conversation

Pablo-Camara
Copy link

@Pablo-Camara Pablo-Camara commented Aug 3, 2021

Fixes #

This fixes YoastSeoForTypo3\YoastSeo\UserFunctions\SnippetPreview,
the render() function has this line:

$additionalGetVars = urldecode(GeneralUtility::_GET('additionalGetVars'));

And for TYPO3 with version less than 9.5 you are not passing the additionalGetVars,
so the SnippetPreview fails to work with my custom "news" record, which needs a "news" GET param..

Resolves #443 , resolves #266

@RinyVT
Copy link
Collaborator

RinyVT commented Aug 12, 2021

Thanks for the pull request! I'll merge it and release a new version soon (along with some other small bugfixes).

@RinyVT RinyVT merged commit 74e0d76 into Yoast:master Aug 12, 2021
@INTERKULTUR
Copy link

INTERKULTUR commented Aug 13, 2021

@RinyVT When will be the premium plugin with this fix available? (eg. 4.1.4)

@RinyVT
Copy link
Collaborator

RinyVT commented Aug 13, 2021

Hi @INTERKULTUR, what do you mean exactly? The premium extension depends on the free extension, so it should be fixed when you update the free extension.

@INTERKULTUR
Copy link

Hi @RinyVT, I bought, downloaded and installed the premium plugin for typo3, not the free one. In my account is still the 4.1.3. How I can safely update this version?

@RinyVT
Copy link
Collaborator

RinyVT commented Aug 13, 2021

@INTERKULTUR The premium version cannot be installed without the free version, the free version should also be available in your installation (premium is built as an expansion of the free extension).
You should have "yoast_seo" and "yoast_seo_premium" both, updating "yoast_seo" should do the trick :D

If you run composer mode you can run `composer update yoast-seo-for-typo3/yoast_seo", if you run non-composer mode you can get the new version at:
https://extensions.typo3.org/extension/yoast_seo

@INTERKULTUR
Copy link

@RinyVT Great, thank you for this information. Now i'm with you. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants