Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Generate absolute url when the site base is only a slash #282

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

RinyVT
Copy link
Collaborator

@RinyVT RinyVT commented Jul 19, 2019

Summary

This PR can be summarized in the following changelog entry:

  • When the base in site configuration is only /, the absolute URL was not generated in the backend. This fix always provides a full url.

Relevant technical choices:

  • When the generated URL has a slash at the first position, the TYPO3_REQUEST_HOST is prepended.

Test instructions

This PR can be tested by following these steps:

  • Set your site base to / and see if the snippet preview in the page module and page properties still shows results.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #279

@RinyVT RinyVT requested a review from haassie July 19, 2019 12:53
@haassie haassie merged commit 11db060 into master Aug 22, 2019
@RinyVT RinyVT deleted the bugfix/279-page-analysis-without-full-domain branch October 5, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analyse page with no full domain in site configuration
2 participants