Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/middleware cache #275

Merged
merged 3 commits into from
Jun 21, 2019
Merged

Bugfix/middleware cache #275

merged 3 commits into from
Jun 21, 2019

Conversation

RinyVT
Copy link
Collaborator

@RinyVT RinyVT commented Jun 14, 2019

Summary

This PR can be summarized in the following changelog entry:

  • Now, when the middleware is active, the pages does not get cached so hidden pages do not end up in the cache

Relevant technical choices:

  • Make usage of the usePageCache hook to check if the middleware is active

Test instructions

This PR can be tested by following these steps:

  • Before you pull this branch, create a hidden page, then edit an existing active page and see if the hidden page ends up in a menu
  • Then pull this branch and see if the problem is fixed

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #272

@RinyVT RinyVT mentioned this pull request Jun 14, 2019
Closed
2 tasks
@RinyVT RinyVT requested a review from haassie June 19, 2019 08:36
@RinyVT RinyVT merged commit 12712d9 into master Jun 21, 2019
@haassie haassie deleted the bugfix/middleware-cache branch April 19, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haassie haassie haassie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snippet preview triggers visibility of inactive sites in frontend menus
2 participants
@RinyVT @haassie