Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigProjectSource might use ConfigGlobalSource #194

Closed
blueyed opened this issue Jan 6, 2017 · 1 comment
Closed

ConfigProjectSource might use ConfigGlobalSource #194

blueyed opened this issue Jan 6, 2017 · 1 comment
Labels
bug

Comments

@blueyed
Copy link
Member

blueyed commented Jan 6, 2017

Given /home/user/project/.vintrc.yaml and /home/user/.vintrc.yaml, ConfigProjectSource will first find the project config, but then also the user's global config, which it then uses instead.

I think a sensible fix for this is to stop once the first config has been found.

Also, ignoring the global config explicitly might make sense.
Vint could stop at the user's home directory to address this?!

Also, ConfigGlobalSource should look at ~/.config/vint/config ($XDG_CONFIG_HOME/yamllint/config) first, which would work around this.
blueyed added a commit to blueyed/vint that referenced this issue Jan 6, 2017
@blueyed
ConfigProjectSource: return first found config
ada886c 
Fixes Vimjas#194.
@blueyed blueyed mentioned this issue Jan 6, 2017
Merged
@Kuniwak Kuniwak added the bug label Jan 8, 2017
Kuniwak pushed a commit that referenced this issue Jan 8, 2017
@blueyed @Kuniwak
ConfigProjectSource: return first found config (#196)
6bda668 
Fixes #194.
@Kuniwak
Copy link
Member

Kuniwak commented Jan 8, 2017

I shipped this bugfix on v0.3.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blueyed @Kuniwak