Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite background-image etc when setting background-color #630

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

M393
Copy link
Contributor

@M393 M393 commented Jul 12, 2021

I use buttons with image background, but the background gets overwritten by the css in Bar.css because it uses the background style instead of background-color This unfortunately also resets background-image / background-position/ background-repeat and a few more styles to their defaults.

It should be enough to only set the background-color here.

This PR deals with toggle buttons only but there's a lot of other places where background is used instead of background-color, maybe consider changing those too.

@Viglino Viglino merged commit b0e3e20 into Viglino:master Jul 13, 2021
@M393 M393 deleted the background-color branch August 12, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants