Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options from TouchCursorSelect should be more openlayers like #705

Closed
domiSchenk opened this issue Dec 1, 2021 · 2 comments
Closed

Options from TouchCursorSelect should be more openlayers like #705

domiSchenk opened this issue Dec 1, 2021 · 2 comments
Labels

Comments

@domiSchenk
Copy link
Contributor

We noticed that the options naming from TouchCursorSelect are not like standard openlayers.
It would be nice if the naming of the available options are the same (doesn't mean it should have all params like ol)
(public naming not the internal!).

options._filter           should be          options.filter


also if I'm correct, there is not filter parameter on getFeaturesAtPixel at least not public:

filter: this._filter,

https://openlayers.org/en/latest/apidoc/module-ol_Map-Map.html#getFeaturesAtPixel

Viglino added a commit that referenced this issue Dec 1, 2021
@Viglino Viglino added the bug label Dec 1, 2021
@Viglino
Copy link
Owner

Viglino commented Dec 1, 2021

Fixed in the last commit

@domiSchenk
Copy link
Contributor Author

perfect, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants