Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executing "npx gulp lib" returns "Did you forget to signal async completion?" message #619

Closed
sanak opened this issue Jun 20, 2021 · 2 comments
Labels

Comments

@sanak
Copy link
Contributor

sanak commented Jun 20, 2021

From #617 (comment).

$ npx gulp lib
[15:32:02] Using gulpfile ~/Projects/gtt-project/git/ol-ext/gulpfile.js
[15:32:02] Starting 'lib'...
[15:32:02] The following tasks did not complete: lib
[15:32:02] Did you forget to signal async completion?

Probably, one of the following answer fix will be necessary.
https://stackoverflow.com/questions/36897877/gulp-error-the-following-tasks-did-not-complete-did-you-forget-to-signal-async

Viglino added a commit that referenced this issue Jun 20, 2021
@Viglino
Copy link
Owner

Viglino commented Jun 20, 2021

The lib script is no more used and was using an old version of gulp and didn't return a completion signal.
The last commit should solve the issue.

@Viglino Viglino added the bug label Jun 20, 2021
@sanak
Copy link
Contributor Author

sanak commented Jun 20, 2021

@Viglino Okay, thanks for quick fix, and sorry for wrong link in #621 PR... 🙇‍♂️
I confirmed that this issue is fixed on the commit abc9489, so I will close this.

@sanak sanak closed this as completed Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants