First review on mouseMoveEvent #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanCaio
commented
Mar 13, 2021
IanCaio
commented
- Fixes small bug with the vertical selection mode scrolling.
- Improves logic on the cursor selection of ActionNone.
- Adds update() + return statements for the actions that didn't have them, and removed the update() from outside the switch.
- Fixes the code style.
Changes variable names from PianoRoll::mousePressEvent to camelCase and changes 2 comments.
…feature/veratilPianoRollMouseRefactor
Removes a loop that removed every note except one and replaced it with a clear() call plus appending the note. Removes a magic number used for finding the closest note.
…feature/veratilPianoRollMouseRefactor
Fixes small bug with the vertical selection mode scrolling. Improves logic on the cursor selection of ActionNone. Adds update() + return statements for the actions that didn't have them, and removed the update() from outside the switch. Fixes the code style.
Veratil
pushed a commit
that referenced
this pull request
Jun 19, 2021
* Changes mousePressEvent variables to camelCase Changes variable names from PianoRoll::mousePressEvent to camelCase and changes 2 comments. * Style fixes on mouseDoubleClickEvent * Removes magic number and costy loop Removes a loop that removed every note except one and replaced it with a clear() call plus appending the note. Removes a magic number used for finding the closest note. * Small fixes + Code style Fixes small bug with the vertical selection mode scrolling. Improves logic on the cursor selection of ActionNone. Adds update() + return statements for the actions that didn't have them, and removed the update() from outside the switch. Fixes the code style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.