-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore game detection #4719
Restore game detection #4719
Conversation
059a07c
to
4103af1
Compare
I see you got this sorted, I will try it the next free time I get. |
operator| doesn't guarantee an evaluation order, so it can lead to surprising results. It's better to use the join member function in this case.
c5ac513
to
da80c7f
Compare
Using the AppImage from this Action build it seems partially fixed, it no longer asks for a game profile every map load of maps previously saved in TrenchBroom or maps with no header information, but we are still missing functionality we previously had before it was removed. It does ask for a game type with the map format is invalid or missing, but not the game type. If the game type is unknown it just out right refuses to load the map or give a choice to pick another game profile. For testing, I opened a map saved in TB in a text editor changing the game profile name to something unknown. Where if I take the same map with unknown game name in the text editor delete or make up a format, save and open in TB then only will it ask for the user to pick another game profile : Instead of refusing to load, it needs to ask for the user to pick another game type. This what we had before. I wish for this functionality to be restored, please. |
da80c7f
to
1ba8ff0
Compare
Good catch, thank you for testing this thoroughly. It should work as before now, please give it another try. |
@eGax did you get a chance to try this? |
Oh yes @kduske , it seems ok now in my testing. |
Closes #4718
@eGax please give this a try