Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore game detection #4719

Merged
merged 4 commits into from
Dec 14, 2024
Merged

Restore game detection #4719

merged 4 commits into from
Dec 14, 2024

Conversation

kduske
Copy link
Collaborator

@kduske kduske commented Dec 10, 2024

Closes #4718

@eGax please give this a try

@kduske kduske added this to the 2024.2 milestone Dec 10, 2024
@kduske kduske force-pushed the restore-game-detection branch 3 times, most recently from 059a07c to 4103af1 Compare December 10, 2024 11:11
@eGax
Copy link
Contributor

eGax commented Dec 10, 2024

Ok, but I don't see any action builds yet, still WIP?

I see you got this sorted, I will try it the next free time I get.

operator| doesn't guarantee an evaluation order, so it can lead to surprising
results. It's better to use the join member function in this case.
@kduske kduske force-pushed the restore-game-detection branch 2 times, most recently from c5ac513 to da80c7f Compare December 10, 2024 21:23
@eGax
Copy link
Contributor

eGax commented Dec 11, 2024

Using the AppImage from this Action build it seems partially fixed, it no longer asks for a game profile every map load of maps previously saved in TrenchBroom or maps with no header information, but we are still missing functionality we previously had before it was removed.

It does ask for a game type with the map format is invalid or missing, but not the game type. If the game type is unknown it just out right refuses to load the map or give a choice to pick another game profile. For testing, I opened a map saved in TB in a text editor changing the game profile name to something unknown.

image

Where if I take the same map with unknown game name in the text editor delete or make up a format, save and open in TB then only will it ask for the user to pick another game profile :

image

Instead of refusing to load, it needs to ask for the user to pick another game type. This what we had before. I wish for this functionality to be restored, please.

@kduske kduske force-pushed the restore-game-detection branch from da80c7f to 1ba8ff0 Compare December 11, 2024 20:58
@kduske
Copy link
Collaborator Author

kduske commented Dec 11, 2024

Good catch, thank you for testing this thoroughly. It should work as before now, please give it another try.

@kduske
Copy link
Collaborator Author

kduske commented Dec 14, 2024

@eGax did you get a chance to try this?

@eGax
Copy link
Contributor

eGax commented Dec 14, 2024

Oh yes @kduske , it seems ok now in my testing.

@kduske kduske merged commit ec17cc2 into master Dec 14, 2024
7 checks passed
@kduske kduske deleted the restore-game-detection branch December 14, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TrenchBroom deletes the game / map type header info from all maps on save.
2 participants