-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create AppImage on CI and stop building debian packages #4676
Conversation
80f4235
to
2373bde
Compare
@eGax If you have some time, could you test the AppImage build a bit? |
I'm on it, OK. |
It won't run for me. Crashes on Arch/Manjaro Linux with this message:
Crashes on Linux Mint 22 with :
Crashes on Fedora with :
|
6f9335b
to
47fa2b8
Compare
Alright this last one now runs on my base Manjaro desktop. https://github.com/TrenchBroom/TrenchBroom/actions/runs/11644739919?pr=4676 I will try the others and use it a bit and see what happens. EDIT So far so good. Runs in Linux Mint under X11 and also runs really well under Fedora with wayland. |
Thanks for testing it! |
Seems to work great! Tested on Arch Linux (2024.11.02). One thing I can point out is that adding EDIT: These packages should about cover it for most setups:
|
Dark mode worked great in Linux Mint under Xfce/GTK already. I wonder what is so different with Arch. I didn't notice anything on Manjaro, but I am running Plasma KDE. |
Ah, never mind I see my mistake. TrenchBroom's Dark mode works, but TrenchBroom is not following system settings when set to a dark setting for GTK environments when set to system. I just went back to recheck in Linux Mint 22 Xfce and Fedora Gnome 3. |
@Settyness I have installed 'qt5ct` but I'm not sure if that is enough to enable the native dark mode support. Could you try the latest AppImage again? |
There is no difference from what I see on my end. |
Ok, looks like it's not possible with AppImage at this time: AppImageCommunity/pkg2appimage#88 |
Well thankfully TrenchBroom includes its own dark mode at least. 👍 This comment definitely sums it up. |
I am very thankful for this appimage and it is going to be a great boon for linux users. Unfortunately it doesn't run on my machine as the glibc version it was built against is too new. Ubuntu 20.04 and other older, LTS distros are still using 2.3X and it might be nice to have a build made using that older version. Other systems like Flatpak would help get around this issue. I can keep building using the docker setup for now! I'll get on a newer system eventually! |
Ubuntu 20.04 goes EOL in April 2025, which is in 3 months from now. It may not be worth decreasing the base distribution TrenchBroom is built against for such a short period of time. By the time all the kinks from reverting to an old version were ironed out, it'd go EOL 🙂 The AppImage is currently built on Ubuntu 22.04, so it should run on any distribution that's roughly as new or newer. This does mean Debian oldstable isn't supported (until Debian |
No description provided.