Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create AppImage on CI and stop building debian packages #4676

Merged
merged 6 commits into from
Dec 8, 2024
Merged

Conversation

kduske
Copy link
Collaborator

@kduske kduske commented Nov 1, 2024

No description provided.

@kduske kduske added this to the 2024.3 milestone Nov 1, 2024
@kduske kduske force-pushed the 2030 branch 5 times, most recently from 80f4235 to 2373bde Compare November 2, 2024 13:57
@kduske
Copy link
Collaborator Author

kduske commented Nov 2, 2024

@eGax If you have some time, could you test the AppImage build a bit?

@eGax
Copy link
Contributor

eGax commented Nov 2, 2024

I'm on it, OK.

@eGax
Copy link
Contributor

eGax commented Nov 2, 2024

It won't run for me.

Crashes on Arch/Manjaro Linux with this message:

This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Crashes on Linux Mint 22 with :

Cannot mix incompatible Qt library (5.15.13) with this library (5.15.3)
Aborted (core dumped)

Crashes on Fedora with :

Warning: Ignoring XDG_SESSION_TYPE=wayland on Gnome. Use QT_QPA_PLATFORM=wayland to run on Wayland anyway.
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Aborted (core dumped)

@kduske kduske force-pushed the 2030 branch 3 times, most recently from 6f9335b to 47fa2b8 Compare November 2, 2024 18:02
@eGax
Copy link
Contributor

eGax commented Nov 2, 2024

Alright this last one now runs on my base Manjaro desktop. https://github.com/TrenchBroom/TrenchBroom/actions/runs/11644739919?pr=4676

I will try the others and use it a bit and see what happens.

EDIT

So far so good. Runs in Linux Mint under X11 and also runs really well under Fedora with wayland.

@kduske
Copy link
Collaborator Author

kduske commented Nov 2, 2024

Thanks for testing it!

@Settyness
Copy link

Settyness commented Nov 3, 2024

Seems to work great! Tested on Arch Linux (2024.11.02). One thing I can point out is that adding qt5ct to the build would hopefully enable dark mode/theming on GTK environments properly configured for it:

Screenshot_2024-11-03_12-58-08

EDIT: These packages should about cover it for most setups:

@eGax
Copy link
Contributor

eGax commented Nov 3, 2024

Dark mode worked great in Linux Mint under Xfce/GTK already. I wonder what is so different with Arch. I didn't notice anything on Manjaro, but I am running Plasma KDE.

@eGax
Copy link
Contributor

eGax commented Nov 3, 2024

Ah, never mind I see my mistake. TrenchBroom's Dark mode works, but TrenchBroom is not following system settings when set to a dark setting for GTK environments when set to system. I just went back to recheck in Linux Mint 22 Xfce and Fedora Gnome 3.

@kduske
Copy link
Collaborator Author

kduske commented Nov 4, 2024

@Settyness I have installed 'qt5ct` but I'm not sure if that is enough to enable the native dark mode support. Could you try the latest AppImage again?

@eGax
Copy link
Contributor

eGax commented Nov 4, 2024

There is no difference from what I see on my end.

@kduske
Copy link
Collaborator Author

kduske commented Nov 4, 2024

Ok, looks like it's not possible with AppImage at this time: AppImageCommunity/pkg2appimage#88

@eGax
Copy link
Contributor

eGax commented Nov 4, 2024

Well thankfully TrenchBroom includes its own dark mode at least. 👍

This comment definitely sums it up.

@kduske kduske modified the milestones: 2024.3, 2024.2 Dec 8, 2024
@kduske kduske merged commit d4a2f65 into master Dec 8, 2024
7 checks passed
@kduske kduske deleted the 2030 branch December 8, 2024 12:53
@smarinel
Copy link

smarinel commented Jan 5, 2025

I am very thankful for this appimage and it is going to be a great boon for linux users.

Unfortunately it doesn't run on my machine as the glibc version it was built against is too new. Ubuntu 20.04 and other older, LTS distros are still using 2.3X and it might be nice to have a build made using that older version.

Other systems like Flatpak would help get around this issue. I can keep building using the docker setup for now!

I'll get on a newer system eventually!

@Calinou
Copy link
Contributor

Calinou commented Jan 8, 2025

Ubuntu 20.04 and other older, LTS distros are still using 2.3X and it might be nice to have a build made using that older version.

Ubuntu 20.04 goes EOL in April 2025, which is in 3 months from now. It may not be worth decreasing the base distribution TrenchBroom is built against for such a short period of time. By the time all the kinks from reverting to an old version were ironed out, it'd go EOL 🙂

The AppImage is currently built on Ubuntu 22.04, so it should run on any distribution that's roughly as new or newer. This does mean Debian oldstable isn't supported (until Debian trixie comes out this summer), but the likelihood you're using Debian oldstable on a desktop PC is quite low in 2025.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants