Project finish #139
Project finish #139
Conversation
There was a problem hiding this comment.
Hey @nikosnick13 👋,
Excellent work on your Flashcards project submission 🎉 !
I have performed a peer review. Review/ignore any comments as you wish.
🔴 App Does Not Build
🐞 Lots of errors in StudySessionController that need resolving.
💡 Make sure you run and test your app before submission!
Please revisit to try understand and fix any issues marked 🔴 , as they block my approval 🚫 .
Feel free to reach out if you have any questions or if you'd like to collaborate further on any of these points 🆘 .
I will go ahead and wait for you to make your changes, commit and push (which will then notify me) 😊 !
Thanks,
@chrisjamiecarter 👍
| private string? connectionString = ConfigurationManager.AppSettings.Get("ConnectionString"); | ||
|
|
||
|
|
||
| public void InsertFlashcart(BasicFlashcardDTO flashcards) |
There was a problem hiding this comment.
🟡 Typo
😆 Easily done!
❌ InsertFlashcart
✔️ InsertFlashcard
| { | ||
| try | ||
| { | ||
| using var conn = new SqlConnection(connectionString); |
There was a problem hiding this comment.
🟢 Using
⭐ Using using statements on Connections.
|
|
||
| } | ||
|
|
||
| //TODO: |
There was a problem hiding this comment.
🟠 Correct comment?
💡 Is this a true statement? Is this TODO? If so, try make a rule that you don't deliver any thing with a TODO comment. Tech debt, you wont come back to it, it will live as a todo forever. If not, try to make sure you do a final revisit and clean up any code comments.
| using System.Text; | ||
| using System.Threading.Tasks; | ||
|
|
||
| namespace Flashcards.nikosnick13.DTOs |
There was a problem hiding this comment.
🟡 Mixed Conventions
💡 You have used block-scoped namespaces here, but file-scoped everywhere else. Try to stick to your conventions, it is better to be consistent than correct.
There was a problem hiding this comment.
🟢 README File
⭐ Great README, well done!
| return userInputAnswer; | ||
| } | ||
|
|
||
| //NOT WORKING TODO: FIX |
There was a problem hiding this comment.
🟠 Comment
💡 Same as before
| @@ -0,0 +1,17 @@ | |||
| namespace FlashStudy.Models | |||
There was a problem hiding this comment.
🔴 Incorrect Namespace
❗ Currently your app does not compile/build.
💡 I had to change to Flashcards.nikosnick13.Models to get it to work.
I finish the project. I am waiting for the review :)