Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:use polaris-all for shading third-party dependencies. #1498

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

SkyeBeFreeman
Copy link
Collaborator

PR Type

Refactoring (no functional changes, no api changes).

Describe what this PR does for and how you did.

Adding the issue link (#xxx) if possible.

closes #1492

Note

Checklist

  • Add information of this PR to CHANGELOG.md in root of project.
  • Add documentation in javadoc or comment below the PR if necessary.

Checklist (Optional)

  • Will pull request to branch of 2023.
  • Will pull request to branch of 2022.
  • Will pull request to branch of 2021.
  • Will pull request to branch of 2020.
  • Will pull request to branch of hoxton.

@SkyeBeFreeman SkyeBeFreeman added this to the 2.0.1.0 milestone Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 62.77372% with 51 lines in your changes missing coverage. Please review.

Project coverage is 63.83%. Comparing base (b12c316) to head (1b43e25).
Report is 1 commits behind head on 2021.

Files with missing lines Patch % Lines
...laris/config/adapter/PolarisConfigFileLocator.java 62.79% 4 Missing and 12 partials ⚠️
...ig/extend/tsf/TsfCoreEnvironmentPostProcessor.java 0.00% 11 Missing ⚠️
.../java/org/springframework/tsf/core/entity/Tag.java 0.00% 7 Missing ⚠️
...olaris/config/adapter/PolarisConfigFilePuller.java 42.85% 0 Missing and 4 partials ⚠️
...registry/tsf/TsfServletRegistrationCustomizer.java 0.00% 4 Missing ⚠️
...nt/cloud/polaris/config/ConfigurationModifier.java 40.00% 1 Missing and 2 partials ⚠️
...nhancement/plugin/DefaultEnhancedPluginRunner.java 71.42% 1 Missing and 1 partial ⚠️
...config/spring/annotation/SpringValueProcessor.java 83.33% 0 Missing and 1 partial ⚠️
...aris/config/spring/property/PlaceholderHelper.java 75.00% 0 Missing and 1 partial ⚠️
...oud/polaris/extend/consul/ConsulDiscoveryUtil.java 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##               2021    #1498      +/-   ##
============================================
+ Coverage     63.81%   63.83%   +0.02%     
  Complexity       22       22              
============================================
  Files           341      338       -3     
  Lines          8111     8108       -3     
  Branches       1007     1005       -2     
============================================
  Hits           5176     5176              
- Misses         2464     2465       +1     
+ Partials        471      467       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shedfreewu
shedfreewu previously approved these changes Feb 25, 2025
Copy link
Collaborator

@shedfreewu shedfreewu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@shedfreewu shedfreewu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SkyeBeFreeman SkyeBeFreeman merged commit 79e549e into Tencent:2021 Feb 25, 2025
10 checks passed
@SkyeBeFreeman SkyeBeFreeman deleted the 21/shade branch February 26, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants