Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:support polaris event. #1494

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

SkyeBeFreeman
Copy link
Collaborator

PR Type

Feature.

Describe what this PR does for and how you did.

Adding the issue link (#xxx) if possible.

Note

Checklist

  • Add information of this PR to CHANGELOG.md in root of project.
  • Add documentation in javadoc or comment below the PR if necessary.

Checklist (Optional)

  • Will pull request to branch of 2023.
  • Will pull request to branch of 2022.
  • Will pull request to branch of 2021.
  • Will pull request to branch of 2020.
  • Will pull request to branch of hoxton.

@SkyeBeFreeman SkyeBeFreeman added this to the 2.0.1.0 milestone Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.03%. Comparing base (a793fd9) to head (396feb8).
Report is 1 commits behind head on 2021.

Files with missing lines Patch % Lines
...nt/cloud/polaris/registry/PolarisRegistration.java 33.33% 2 Missing ⚠️
...laris/registry/PolarisAutoServiceRegistration.java 93.33% 0 Missing and 1 partial ⚠️
.../event/PushGatewayEventReporterConfigModifier.java 94.11% 0 Missing and 1 partial ⚠️
...text/event/PushGatewayEventReporterProperties.java 94.11% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2021    #1494      +/-   ##
============================================
+ Coverage     66.83%   67.03%   +0.19%     
  Complexity       22       22              
============================================
  Files           333      335       +2     
  Lines          7837     7890      +53     
  Branches        980      983       +3     
============================================
+ Hits           5238     5289      +51     
- Misses         2124     2125       +1     
- Partials        475      476       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@shedfreewu shedfreewu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SkyeBeFreeman SkyeBeFreeman merged commit 5da0916 into Tencent:2021 Feb 17, 2025
10 checks passed
@SkyeBeFreeman SkyeBeFreeman deleted the 21/event branch February 17, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants