Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove version-hardcofing from Sphinx #128

Conversation

ryo-takahashi-1206
Copy link
Collaborator

@ryo-takahashi-1206 ryo-takahashi-1206 commented Sep 14, 2022

In order to resolve #116, I propose to use git describe.
In future, I will fold past major release into the single doc as other popular projects do.

This change is Reviewable

@ryo-takahashi-1206 ryo-takahashi-1206 marked this pull request as ready for review September 14, 2022 02:18
Copy link
Collaborator

@tk-woven tk-woven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! :lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sshusainTRI and @ykkawana-woven)

@ryo-takahashi-1206 ryo-takahashi-1206 merged commit 634a4ec into TRI-ML:master Sep 14, 2022
@ryo-takahashi-1206 ryo-takahashi-1206 deleted the remove-version-hardcoding/rev-1 branch September 14, 2022 03:48
@ryo-takahashi-1206
Copy link
Collaborator Author

I want to apologize my stupid mistake...
https://github.com/TRI-ML/dgp/actions/runs/3050002270/jobs/4916646308
I will fix this matter ASASP 🙇

@tk-woven
Copy link
Collaborator

No worries! We can also revert if need be, so you don't have to panic :) I skimmed the error output, but it's not immediately clear what the issue is. Is git not available on the PATH?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs build tracks latest docs but shows old version
2 participants