-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add GitHub issue templates with default assignees #127
feat: add GitHub issue templates with default assignees #127
Conversation
69a492e
to
39085b4
Compare
39085b4
to
ae9a5ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added Wadim after discussing with him in-person.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @chrisochoatri, @kuanleetri, @ryo-takahashi-1206, @wadimkehl, and @ykkawana-woven)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR 🙇
I confirmed the default assignees are set according to our last dicusssion.
Of course, no objection
Reviewed 3 of 3 files at r1.
Reviewable status: 1 of 3 files reviewed, all discussions resolved (waiting on @chrisochoatri, @kuanleetri, @ryo-takahashi-1206, @wadimkehl, and @ykkawana-woven)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, all discussions resolved (waiting on @chrisochoatri, @kuanleetri, @ryo-takahashi-1206, @wadimkehl, and @ykkawana-woven)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Ryo-san!
Reviewable status: 1 of 3 files reviewed, all discussions resolved (waiting on @chrisochoatri, @kuanleetri, @ryo-takahashi-1206, @wadimkehl, and @ykkawana-woven)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICE!
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @chrisochoatri, @kuanleetri, and @ykkawana-woven)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll merge, and we can make adjustments based on others' feedback later if need be.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @chrisochoatri, @kuanleetri, and @ykkawana-woven)
Description
This introduces issue templates for GitHub issues. Issue templates present issue creators with options between different pre-populated issue bodies. See FAIR's Detectron2 New-Issues for an example.
This also adds a number of default assignees. The default assignees are not required to solve the issues themselves, but they are added so that at least someone gets a notification when a new issue is opened. This way we can triage or re-assign as needed.
This change is