-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace last SuperLinter check yamllint
with pre-commit hook
#124
feat: replace last SuperLinter check yamllint
with pre-commit hook
#124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I hope we can move fast on this one. The SuperLinter is a nightmare
Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tk-woven)
28a8b4c
to
05f425a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I had to rebase on master but otherwise am good-to-go now.
Reviewable status: 7 of 15 files reviewed, all discussions resolved (waiting on @chrisochoatri, @kuanleetri, and @wadimkehl)
Still unresolved conflicts? |
Odd; there were some diffs in your recent merges to the conflicting files. Those diffs came from my previously-merged commits. Not sure what's going on here, but yes, more conflicts that I'll resolve! |
05f425a
to
ea11891
Compare
I see, it was the combination of my changes reflowing some YAML and your changes bumping the Python version in them :) |
This also removes SuperLinter from DGP since all utilized checks have been migrated to pre-commit.
ea11891
to
3537411
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 8 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @chrisochoatri and @kuanleetri)
Description
This concludes #114 . This introduces the
yamllint
pre-commit hook, runs it on all files, and touches up some violations. It also introduces a configuration foryamllint
to ignore some checks that we don't need or otherwise modify them.This is the last SuperLinter check to migrate, so this work also removes SuperLinter from CI.
This change is