Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace last SuperLinter check yamllint with pre-commit hook #124

Conversation

tk-woven
Copy link
Collaborator

@tk-woven tk-woven commented Aug 15, 2022

Description

This concludes #114 . This introduces the yamllint pre-commit hook, runs it on all files, and touches up some violations. It also introduces a configuration for yamllint to ignore some checks that we don't need or otherwise modify them.

This is the last SuperLinter check to migrate, so this work also removes SuperLinter from CI.


This change is Reviewable

wadimkehl
wadimkehl previously approved these changes Aug 20, 2022
Copy link
Collaborator

@wadimkehl wadimkehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I hope we can move fast on this one. The SuperLinter is a nightmare

Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tk-woven)

@tk-woven tk-woven force-pushed the feat/tyler-kowallis/use-pre-commit-for-linting-4 branch from 28a8b4c to 05f425a Compare August 22, 2022 23:14
@tk-woven tk-woven marked this pull request as ready for review August 22, 2022 23:14
Copy link
Collaborator Author

@tk-woven tk-woven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I had to rebase on master but otherwise am good-to-go now.

Reviewable status: 7 of 15 files reviewed, all discussions resolved (waiting on @chrisochoatri, @kuanleetri, and @wadimkehl)

@wadimkehl
Copy link
Collaborator

Still unresolved conflicts?

@tk-woven
Copy link
Collaborator Author

Odd; there were some diffs in your recent merges to the conflicting files. Those diffs came from my previously-merged commits. Not sure what's going on here, but yes, more conflicts that I'll resolve!

@tk-woven tk-woven force-pushed the feat/tyler-kowallis/use-pre-commit-for-linting-4 branch from 05f425a to ea11891 Compare August 23, 2022 02:36
@tk-woven
Copy link
Collaborator Author

I see, it was the combination of my changes reflowing some YAML and your changes bumping the Python version in them :)

This also removes SuperLinter from DGP since all utilized checks have
been migrated to pre-commit.
@tk-woven tk-woven force-pushed the feat/tyler-kowallis/use-pre-commit-for-linting-4 branch from ea11891 to 3537411 Compare August 23, 2022 02:43
Copy link
Collaborator

@wadimkehl wadimkehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @chrisochoatri and @kuanleetri)

@tk-woven tk-woven merged commit 889d8b6 into TRI-ML:master Aug 23, 2022
@tk-woven tk-woven deleted the feat/tyler-kowallis/use-pre-commit-for-linting-4 branch August 23, 2022 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants