We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When I add a string without the binary option, it is treated as an unicode string.
binary
zip.file("txt", "é"); zip.file("txt").async("text").then((txt) => console.log(txt)); > é
When I add a promise of string without the binary option, it is treated as a binary string.
zip.file("txt", Promise.resolve("é")); zip.file("txt").async("text").then((txt) => console.log(txt)); > �
Expected: same behavior between the two use cases.
Note to self: also fix the documentation of binary which is quite confusing.
The text was updated successfully, but these errors were encountered:
Honor the options.binary flag.
aad724b
It mitigates Stuk#325: a promise of text can now be handled with `{binary:false}`.
No branches or pull requests
When I add a string without the
binary
option, it is treated as an unicode string.When I add a promise of string without the
binary
option, it is treated as a binary string.Expected: same behavior between the two use cases.
Note to self: also fix the documentation of
binary
which is quite confusing.The text was updated successfully, but these errors were encountered: