Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image is outdated on Docker Hub #4

Open
daniel-lerch opened this issue Jul 4, 2023 · 9 comments
Open

Image is outdated on Docker Hub #4

daniel-lerch opened this issue Jul 4, 2023 · 9 comments

Comments

@daniel-lerch
Copy link

The latest published stable tag on Docker Hub is v4.39-9772-beta.

However, in the meantime there have been three more stable releases:

Will these releases be published to Docker Hub? I'd be happy to contribute a PR if necessary.

@weidi
Copy link
Collaborator

weidi commented Jul 5, 2023

i just pushed the missing stable releases.
Tried to also do this using github CI but was so far not succesfull getting the automatic tagging done so i´m happy if you know how to do it.

@daniel-lerch
Copy link
Author

Thank you very much updating!

In order to help you with the tagging you will have to describe or add to documentation of this repo, how the GitHub Actions CI pipeline is triggered. How do you get the releases from both SoftEther source repositories?

@weidi
Copy link
Collaborator

weidi commented Jul 6, 2023

I was hoping to get this done by tagging a commit with the respective version but receiving
v4.41-9787-rtm is not a valid semver. More info: https://semver.org/

@j123b567
Copy link

As my understanding

  • semver should have 3 digits 4.41.9787 is valid semver, 4.41-9787 is not
  • semver does not know -rtm suffix and it is considered as prerelease
  • semver should not have v prefix

@weidi
Copy link
Collaborator

weidi commented Jan 30, 2025

Thank you very much updating!

In order to help you with the tagging you will have to describe or add to documentation of this repo, how the GitHub Actions CI pipeline is triggered. How do you get the releases from both SoftEther source repositories?

Probably we should implement something like https://github.com/peter-evans/repository-dispatch to trigger actions on tagging in the stable and dev repository so we never miss a release. @chipitsine what do you think?

@chipitsine
Copy link
Member

chipitsine commented Feb 9, 2025

I tried to move your build definitions to my fork of SE VPN

https://github.com/chipitsine/SoftEtherVPN/blob/master/.github/workflows/docker-vpnserver.yml

currently I'm struggling with alpine segfaults on qemu: docker/build-push-action#1319

yep, I noticed self-hosted "ARM64" runner attached by you. if we won't be able to figure out how to build arm64 on github hosted, we'll think about it. but I beleive building on github hosted runner is something very-very-very common.

stay tuned.

btw, if you can review my approach, I'll appreciate it (I tried to borrow your implementation and pack into matrix)

also, I keep in mind, if we will not manage moving build definitions to the main repo, say in 1-2 weeks, we'll implement a trigger mentioned by you

@weidi
Copy link
Collaborator

weidi commented Feb 9, 2025

Matrix seems to be a nice way, hope you find a solution for the segfault thing, IMHO this is down to the BLAKE2 way of getting CPUinfo and misses SSE2 on ARM.
the selfhosted arm64 runs in oracle cloud as its free so no problem to keep it running this way but for sure the gihub runner is the way better approach especcialy as this would lead to avoid different tags for arm64 images.

@chipitsine
Copy link
Member

it failed because of qemu bug (fixed, but qemu is not updated)

https://github.com/chipitsine/SoftEtherVPN/actions/runs/13229596049/job/36924891267

btw, we'll need to use better approach of "RUN git clone https://github.com/SoftEtherVPN/SoftEtherVPN.git" in Dockerfile
it works when Dockerfile is external to the repo, but if we build from inside, we should use local files

chipitsine added a commit to chipitsine/SoftEtherVPN that referenced this issue Feb 9, 2025
@chipitsine
Copy link
Member

@weidi , what I didn't try yet - what happens on tagged branch (pushing to master seems work ok). tagged I'll test after merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants