feat: switch to new chromium headless mode #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert debian->alpine change Add --headless=new
Fix svg regex
ariwk
reviewed
Mar 12, 2025
| @@ -16,7 +16,7 @@ | |||
|
|
|||
| # Process img tags, replacing base64 SVG images with PNGs | |||
| def process_svg(html: str) -> str: | |||
| pattern = re.compile(r'<img(?P<intermediate>[^>]+?src="data:)(?P<type>[^;>]+)?;base64,(?P<base64>[^"]+)?"') | |||
| pattern = re.compile(r'<img(?P<intermediate>[^>]+?src="data:)(?P<type>[^;>]+)?;base64,\s?(?P<base64>[^">]+)?"') | |||
There was a problem hiding this comment.
When I updated this repository with the repo template, I adjusted the regex to take fewer steps
But I overlooked those two characters
There was a problem hiding this comment.
the old implementation was:
pattern = re.compile(r'<img(?P[^>]+?src="data:)(?P[^;>]?);base64,\s?(?P[^">]?)"')
|
grigoriev
reviewed
Mar 12, 2025
| @@ -156,7 +156,7 @@ def create_chromium_command(width: int, height: int, png_filepath: Path, svg_fil | |||
|
|
|||
| command = [ | |||
| chromium_executable, | |||
| "--headless=old", | |||
| "--headless=new", | |||
There was a problem hiding this comment.
changing headless mode to new introduces the issue that bottom part of SVG is cut
Fix new headless bottom cut problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert debian->alpine change
Add --headless=new
Proposed changes
Switch back to debian and use new headless mode
Checklist
Before creating a PR, run through this checklist and mark each as complete:
CONTRIBUTINGdocument