Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional close button and custom background color for modal sheet and popup (#293) #296

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

rawi-coding
Copy link
Contributor

@rawi-coding rawi-coding commented Mar 11, 2025

closes #293

@rawi-coding rawi-coding requested a review from a team as a code owner March 11, 2025 10:54
Copy link
Contributor

@smallTrogdor smallTrogdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for contributing @rawi-coding !

Three things:

  • CI fails, because the spacing parameter is not yet supported for the oldest Flutter SDK we still support (was introduced in 3.27.0)
  • please add your changes to the Changelog
  • please add a golden test for your changes

Thanks again!

@rawi-coding
Copy link
Contributor Author

Looks good, thanks for contributing @rawi-coding !

Three things:

  • CI fails, because the spacing parameter is not yet supported for the oldest Flutter SDK we still support (was introduced in 3.27.0)
  • please add your changes to the Changelog
  • please add a golden test for your changes

Thanks again!

Thanks for your review @smallTrogdor. I made the changes you mentioned :)

@smallTrogdor smallTrogdor self-requested a review March 11, 2025 15:04
Copy link
Contributor

@smallTrogdor smallTrogdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @rawi-coding

@smallTrogdor smallTrogdor merged commit bef32b5 into main Mar 11, 2025
8 checks passed
@smallTrogdor smallTrogdor deleted the 293-modal-sheet-optional-close-button branch March 11, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Modal Sheet with optional close button
2 participants