feat: optional close button and custom background color for modal sheet and popup (#293) #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallTrogdor
requested changes
Mar 11, 2025
There was a problem hiding this comment.
Looks good, thanks for contributing @rawi-coding !
Three things:
- CI fails, because the
spacingparameter is not yet supported for the oldest Flutter SDK we still support (was introduced in 3.27.0) - please add your changes to the Changelog
- please add a golden test for your changes
Thanks again!
Thanks for your review @smallTrogdor. I made the changes you mentioned :) |
smallTrogdor
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #293