feat: implement custom promotionbox (#294) #295
Conversation
There was a problem hiding this comment.
Thanks for contributing! Looks good and makes customization possible!
Three things before merging and release:
- The non const default constructor might be a breaking change (would like to avoid that) (alternative would be to separate the content creation into a const private Widget?)
- Missing documentation (at least Changelog)
- Missing Semantics (can add this separately though)
| ], | ||
| if (widget.leading != null) | ||
| Padding( | ||
| padding: const EdgeInsets.fromLTRB(0, 0, 8.0, 0), |
There was a problem hiding this comment.
EdgeInsets.only(right: 8.0)
Also not so sure whether we should just add padding by default or leave that to the user ... would prefer that
There was a problem hiding this comment.
I would leave the padding, otherwise we could just provide a "content" widget and not even bother with leading and trailing
| @@ -7,26 +7,125 @@ import 'promotion_badge.dart'; | |||
| part 'promotion_box.assets.dart'; | |||
|
|
|||
| class SBBPromotionBox extends StatefulWidget { | |||
| const SBBPromotionBox({ | |||
There was a problem hiding this comment.
hm, thinking whether we would need to treat the non const constructor as a breaking change...
There was a problem hiding this comment.
Will treat it as a Breaking change and adapt the Changelog in separate PR accordingly.
Thanks @Grodien for the contribution!
No description provided.