Reposition sections when setActiveSection API is called by app creator #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmslachciak
force-pushed
the
lslachciak-repos
branch
from
4b4aedf to
3a4495e
Compare
lmslachciak
force-pushed
the
lslachciak-repos
branch
from
3a4495e to
a2395c5
Compare
TomaszLukawskiSam
requested changes
Mar 4, 2020
| @@ -510,7 +510,7 @@ | |||
| * or with touch events | |||
| * @member ns.widget.core.SectionChanger | |||
| */ | |||
| setActiveSection: function (index, duration, direct) { | |||
| setActiveSection: function (index, duration, direct, reposition) { | |||
There was a problem hiding this comment.
Please add js doc for reposition.
[Issue] #659 [Problem] When calling setActiveSection API directly in app, in case of swipe strange animation occurs [Reason] Normally _repositionSections method is called when widget is initialized. When ui-section-active not set all values will be initialized with default ones. When developers calls setActiveSection directly method _repositionSections is not called [Solution] Call _repositionSections inside setActiveSection Signed-off-by: Lukasz Slachciak <[email protected]>
lmslachciak
force-pushed
the
lslachciak-repos
branch
from
a2395c5 to
98cddb2
Compare
TomaszLukawskiSam
approved these changes
Mar 5, 2020
lmslachciak
added a commit
to lmslachciak/TAU
that referenced
this pull request
Apr 29, 2020
Dedicated platform: Tizen 6.0, Tizen 5.0 New features in 1.2.0: - support for OneUI 2.x Changes in version 1.2.1: 26de433 (mobile) Recover rounded corners on ui-content element d5c660a (svace) Replacing localstorege by document.cookie in PanelChanger 1eddf30 Fix rendering issue in onoff switch. Apply guidelines. 1a747ff Remove disabled examples for on-off switch and radio button 155b18e (mobile) Fix for footer with buttons a8caeb2 TimePicker (Wearable): update AM/PM on _setValue 5ca2fef Update the sample menu 1fde69e (svace) ToggleSwitch.extra - remove unnecesary "return" f9bc915 Radio/OnOff-Switch Sample update d698f41 (SVACE) Fix for browser.ie detect method 0950eae (SVACE) Replace localstorage by document.cookie 50ebe14 UIComponents (NumberPicker): save number on "Set" button 63c0ba1 List (mobile): Add a height between title and sub text f603063 List (mobile): Fix to apply the GUI feedback 332c98e [mobile] Fix padding and dropdown list options height 290970e (SVACE) Fix for getPrefixedStyleValue method db3e9e1 UIComponents (Pickers): save Date/Time on "Set" button 3b4b24c MainTab: implementation of widget based on TabBar widget 192b8aa Fix for icon color for button in AppBar widget 1793290 [mobile] Apply Winner screen width to the dialog fb9138e UIComponents (OnOffSwitch) : fix Back key operation f7fbb7c [mobile] Add padding to Date picker (Calendar view) 4da1494 (UIComponents) fix for Master On-Off example f38f9e8 Merge pull request Samsung#995 from lslachciak/t12 353b123 UIComponents (TextInput): save data on "Save" button 45a9a19 BaseKeyboardSupport.js (SVACE): remove return from _onShortPress c7ce6e4 BaseKeyboardSupport.js (SVACE): early return in case of wrong direction 172ec23 Checkboxradio.js (SVACE): do not always return the same value 1fe4171 DropdownMenu.js (SVACE): add return to _configure 7611e11 BaseKeyboardSupport.js (SVACE): add return to getDistanceByDirection ecfdd8c Drawe.js (SVACE): check right position c03c6bb Dimmer.js (SVACE): add return to _refreshValue cdeac89 Remove unneded file after merge 74df016 List (mobile): Fix to apply a GUI feedback part.2 b629947 [mobile] Change default color of checkbox and radio button b94d61d [mobile] Fix dialog to GUI feedback 061fecc [mobile] fixup! fix dialog sample link 0a6c08e List (mobile): Fix to apply GUI feedback f91d3ce Fix spelling errors introduced in TAU 1.2 df5f63e Merge remote-tracking branch 'origin/tau_1.1' into HEAD b3d3f49 Merge pull request Samsung#994 from lslachciak/t11m b504dc5 Fix spelling errors introduced in 1.1 02cc20a Merge remote-tracking branch 'origin/tau_1.0' into HEAD 0516f71 Fix typo errors in code d464103 Enable spellcheck for additional files c62462e (UIComponents) Fix for url of link in "contained" button example cbd658d [mobile] Fix the checkbox dialog gap according to the GUI guide d166e26 BaseKeyboardSupport.js (SVACE): add return to filterNeighbors 85b3d0a BaseKeyboardSupport.js (SVACE): add conversion to Boolean c0f4017 BaseKeyboardSupport (SVACE): remove unnecessary argument ec434a6 Graph.js (SVACE): add return value for _build func 8cc4cbd On/Off switch : Fix to apply GUI feedback 299de69 (mobile): Implement a date picker 3162c57 Page (mobile): Fix to calculate the correct size of header 289f476 Bottom bar : Fix to apply GUI feedback 19c32c0 [mobile] Add progressbar to the dialog sample 0f3fec3 TextInput (wearable): Input element is broken with number type 8f49737 Graph.js (SVACE): move defaults before its usage 05b9be9 Appbar.js (SVACE): move states before its usage 3242137 Calendar.js (SVACE): move defaultOptions before its usage 09b91d9 BaseKeyboardSupport.js (SVACE): move selectorsString before its usage 290a671 List Divider (Wearable): update example and style 375d906 [mobile] Add slider to the dialog sample 7aeddea (tests) Fix for test of util/polar 7d7ae30 Bump eslint from 3.19.0 to 4.18.2 (Samsung#676) 6f252c0 Reposition sections when setActiveSection API is called by app creator (Samsung#687) Signed-off-by: Lukasz Slachciak <[email protected]>
Merged
lmslachciak
added a commit
to lmslachciak/TAU
that referenced
this pull request
Apr 29, 2020
Dedicated platform: Tizen 6.0 New features in 1.2.0: - support for OneUI 2.x Changes in version 1.2.1: 26de433 (mobile) Recover rounded corners on ui-content element d5c660a (svace) Replacing localstorege by document.cookie in PanelChanger 1eddf30 Fix rendering issue in onoff switch. Apply guidelines. 1a747ff Remove disabled examples for on-off switch and radio button 155b18e (mobile) Fix for footer with buttons a8caeb2 TimePicker (Wearable): update AM/PM on _setValue 5ca2fef Update the sample menu 1fde69e (svace) ToggleSwitch.extra - remove unnecesary "return" f9bc915 Radio/OnOff-Switch Sample update d698f41 (SVACE) Fix for browser.ie detect method 0950eae (SVACE) Replace localstorage by document.cookie 50ebe14 UIComponents (NumberPicker): save number on "Set" button 63c0ba1 List (mobile): Add a height between title and sub text f603063 List (mobile): Fix to apply the GUI feedback 332c98e [mobile] Fix padding and dropdown list options height 290970e (SVACE) Fix for getPrefixedStyleValue method db3e9e1 UIComponents (Pickers): save Date/Time on "Set" button 3b4b24c MainTab: implementation of widget based on TabBar widget 192b8aa Fix for icon color for button in AppBar widget 1793290 [mobile] Apply Winner screen width to the dialog fb9138e UIComponents (OnOffSwitch) : fix Back key operation f7fbb7c [mobile] Add padding to Date picker (Calendar view) 4da1494 (UIComponents) fix for Master On-Off example f38f9e8 Merge pull request Samsung#995 from lslachciak/t12 353b123 UIComponents (TextInput): save data on "Save" button 45a9a19 BaseKeyboardSupport.js (SVACE): remove return from _onShortPress c7ce6e4 BaseKeyboardSupport.js (SVACE): early return in case of wrong direction 172ec23 Checkboxradio.js (SVACE): do not always return the same value 1fe4171 DropdownMenu.js (SVACE): add return to _configure 7611e11 BaseKeyboardSupport.js (SVACE): add return to getDistanceByDirection ecfdd8c Drawe.js (SVACE): check right position c03c6bb Dimmer.js (SVACE): add return to _refreshValue cdeac89 Remove unneded file after merge 74df016 List (mobile): Fix to apply a GUI feedback part.2 b629947 [mobile] Change default color of checkbox and radio button b94d61d [mobile] Fix dialog to GUI feedback 061fecc [mobile] fixup! fix dialog sample link 0a6c08e List (mobile): Fix to apply GUI feedback f91d3ce Fix spelling errors introduced in TAU 1.2 df5f63e Merge remote-tracking branch 'origin/tau_1.1' into HEAD b3d3f49 Merge pull request Samsung#994 from lslachciak/t11m b504dc5 Fix spelling errors introduced in 1.1 02cc20a Merge remote-tracking branch 'origin/tau_1.0' into HEAD 0516f71 Fix typo errors in code d464103 Enable spellcheck for additional files c62462e (UIComponents) Fix for url of link in "contained" button example cbd658d [mobile] Fix the checkbox dialog gap according to the GUI guide d166e26 BaseKeyboardSupport.js (SVACE): add return to filterNeighbors 85b3d0a BaseKeyboardSupport.js (SVACE): add conversion to Boolean c0f4017 BaseKeyboardSupport (SVACE): remove unnecessary argument ec434a6 Graph.js (SVACE): add return value for _build func 8cc4cbd On/Off switch : Fix to apply GUI feedback 299de69 (mobile): Implement a date picker 3162c57 Page (mobile): Fix to calculate the correct size of header 289f476 Bottom bar : Fix to apply GUI feedback 19c32c0 [mobile] Add progressbar to the dialog sample 0f3fec3 TextInput (wearable): Input element is broken with number type 8f49737 Graph.js (SVACE): move defaults before its usage 05b9be9 Appbar.js (SVACE): move states before its usage 3242137 Calendar.js (SVACE): move defaultOptions before its usage 09b91d9 BaseKeyboardSupport.js (SVACE): move selectorsString before its usage 290a671 List Divider (Wearable): update example and style 375d906 [mobile] Add slider to the dialog sample 7aeddea (tests) Fix for test of util/polar 7d7ae30 Bump eslint from 3.19.0 to 4.18.2 (Samsung#676) 6f252c0 Reposition sections when setActiveSection API is called by app creator (Samsung#687) Signed-off-by: Lukasz Slachciak <[email protected]>
lmslachciak
added a commit
that referenced
this pull request
Apr 29, 2020
Dedicated platform: Tizen 6.0 New features in 1.2.0: - support for OneUI 2.x Changes in version 1.2.1: 26de433 (mobile) Recover rounded corners on ui-content element d5c660a (svace) Replacing localstorege by document.cookie in PanelChanger 1eddf30 Fix rendering issue in onoff switch. Apply guidelines. 1a747ff Remove disabled examples for on-off switch and radio button 155b18e (mobile) Fix for footer with buttons a8caeb2 TimePicker (Wearable): update AM/PM on _setValue 5ca2fef Update the sample menu 1fde69e (svace) ToggleSwitch.extra - remove unnecesary "return" f9bc915 Radio/OnOff-Switch Sample update d698f41 (SVACE) Fix for browser.ie detect method 0950eae (SVACE) Replace localstorage by document.cookie 50ebe14 UIComponents (NumberPicker): save number on "Set" button 63c0ba1 List (mobile): Add a height between title and sub text f603063 List (mobile): Fix to apply the GUI feedback 332c98e [mobile] Fix padding and dropdown list options height 290970e (SVACE) Fix for getPrefixedStyleValue method db3e9e1 UIComponents (Pickers): save Date/Time on "Set" button 3b4b24c MainTab: implementation of widget based on TabBar widget 192b8aa Fix for icon color for button in AppBar widget 1793290 [mobile] Apply Winner screen width to the dialog fb9138e UIComponents (OnOffSwitch) : fix Back key operation f7fbb7c [mobile] Add padding to Date picker (Calendar view) 4da1494 (UIComponents) fix for Master On-Off example f38f9e8 Merge pull request #995 from lslachciak/t12 353b123 UIComponents (TextInput): save data on "Save" button 45a9a19 BaseKeyboardSupport.js (SVACE): remove return from _onShortPress c7ce6e4 BaseKeyboardSupport.js (SVACE): early return in case of wrong direction 172ec23 Checkboxradio.js (SVACE): do not always return the same value 1fe4171 DropdownMenu.js (SVACE): add return to _configure 7611e11 BaseKeyboardSupport.js (SVACE): add return to getDistanceByDirection ecfdd8c Drawe.js (SVACE): check right position c03c6bb Dimmer.js (SVACE): add return to _refreshValue cdeac89 Remove unneded file after merge 74df016 List (mobile): Fix to apply a GUI feedback part.2 b629947 [mobile] Change default color of checkbox and radio button b94d61d [mobile] Fix dialog to GUI feedback 061fecc [mobile] fixup! fix dialog sample link 0a6c08e List (mobile): Fix to apply GUI feedback f91d3ce Fix spelling errors introduced in TAU 1.2 df5f63e Merge remote-tracking branch 'origin/tau_1.1' into HEAD b3d3f49 Merge pull request #994 from lslachciak/t11m b504dc5 Fix spelling errors introduced in 1.1 02cc20a Merge remote-tracking branch 'origin/tau_1.0' into HEAD 0516f71 Fix typo errors in code d464103 Enable spellcheck for additional files c62462e (UIComponents) Fix for url of link in "contained" button example cbd658d [mobile] Fix the checkbox dialog gap according to the GUI guide d166e26 BaseKeyboardSupport.js (SVACE): add return to filterNeighbors 85b3d0a BaseKeyboardSupport.js (SVACE): add conversion to Boolean c0f4017 BaseKeyboardSupport (SVACE): remove unnecessary argument ec434a6 Graph.js (SVACE): add return value for _build func 8cc4cbd On/Off switch : Fix to apply GUI feedback 299de69 (mobile): Implement a date picker 3162c57 Page (mobile): Fix to calculate the correct size of header 289f476 Bottom bar : Fix to apply GUI feedback 19c32c0 [mobile] Add progressbar to the dialog sample 0f3fec3 TextInput (wearable): Input element is broken with number type 8f49737 Graph.js (SVACE): move defaults before its usage 05b9be9 Appbar.js (SVACE): move states before its usage 3242137 Calendar.js (SVACE): move defaultOptions before its usage 09b91d9 BaseKeyboardSupport.js (SVACE): move selectorsString before its usage 290a671 List Divider (Wearable): update example and style 375d906 [mobile] Add slider to the dialog sample 7aeddea (tests) Fix for test of util/polar 7d7ae30 Bump eslint from 3.19.0 to 4.18.2 (#676) 6f252c0 Reposition sections when setActiveSection API is called by app creator (#687) Signed-off-by: Lukasz Slachciak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Issue] #659
[Problem] When calling setActiveSection API directly in app, in case of swipe strange animation occurs
[Reason] Normally _repositionSections method is called when widget is initialized.
When ui-section-active not set all values will be initialized with default ones.
When developers calls setActiveSection directly method _repositionSections is not called
[Solution] Call _repositionSections inside setActiveSection
Signed-off-by: Lukasz Slachciak [email protected]