Fix v2.0.4 sage #31
Merged
Fix v2.0.4 sage #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelasilva
force-pushed
the
fix_v2.0.4-sage
branch
from
3241528 to
f3a77da
Compare
ianoxley
reviewed
Jul 24, 2024
ianoxley
reviewed
Jul 25, 2024
zuora.gemspec
Outdated
| @@ -31,6 +31,7 @@ Gem::Specification.new do |s| | |||
| s.add_development_dependency 'rspec' | |||
| s.add_development_dependency 'simplecov' | |||
| s.add_development_dependency 'test-unit' | |||
| s.add_development_dependency 'timecop' | |||
| s.add_development_dependency 'yard' | |||
| s.add_dependency 'akami' | |||
| s.add_dependency 'httpi' | |||
There was a problem hiding this comment.
Can we remove httpi as a dependency please? That is a dependency of savon < 3.
Can we change the savon dependency to guard against using v3.0.0 when it's released? That version replaces httpi with faraday and contains breaking changes.
s.add_dependency 'savon', '< 3'
…sed, as it introduces breaking changes.
ianoxley
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the merging of the original zuora repository into the forked repository, a lot of breaking changes were introduced which then caused the zuora integrations with our apps to stop working as expected.
Resolution Approach
We took an older working version and added the minimum required changes to resolve the dependency errors experienced without bringing the whole breaking changes into this branch.