TLS key logging #781
Merged
TLS key logging #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orgads
reviewed
Mar 11, 2025
|
Looks good, thank you. Can you please squash all the commits except the cmake one, and use a descriptive commit message (you can take it from the PR description I guess)? |
|
I hope I got you right, please check. |
TLS key logging records the TLS Session Keys to a key log file when the SSLKEYLOGFILE environment variable is set. It allows to decrypt SIPS traffic generated or received by SIPp using Wireshark. For more details see: https://wiki.wireshark.org/TLS/. A description of the TLS key log format can be found here: https://datatracker.ietf.org/doc/draft-ietf-tls-keylogfile/
|
I now noticed that the cmake change relates to the first commit, so I just squashed everything. I also wrapped the commit message. LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLS key logging records the TLS Session Keys to a key log file when the
SSLKEYLOGFILEenvironment variable is set. It allows to decrypt SIPS traffic generated or received by SIPp using Wireshark. For more details see: https://wiki.wireshark.org/TLSThe TLS key log file format is described here: https://datatracker.ietf.org/doc/draft-ietf-tls-keylogfile/