Update dtd #425
Merged
Update dtd #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I attempted writing my own custom scenarios using the DTD as a guide, but found that there were several errors in it. This patch re-writes the DID based on the docs found on [Read The Docs][1]. There's still some improvements that can happen, but this seems to work much better. [1]: https://sipp.readthedocs.io/en/v3.6.0/scenarios/ownscenarios.html
- Added timewait element - Added #PCDATA as child of send - Correct request attribute - Add rtp_echo element - Add Reference element - Add start_line attribute - Correct name of rrs attribute
|
Thanks! I've merged this and also raised #432, which validates all .xml files in the source tree against the DTD as part of our CI, which should keep this working in future. (I've also made one further fix to the DTD - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into some issues using the current DTD to write custom scenarios. There were enough errors and confusing organization that I rewrote it.