Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash when exiting thread on sendto() failure #370

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

treyadg
Copy link
Contributor

@treyadg treyadg commented Nov 10, 2018

pthread_cleanup_pop() should be called after calling pthread_cleanup_push(), in case of sendto() failure, the function will return without calling pthread_cleanup_pop() which will cause sipp to crash with segfault.

@treyadg treyadg closed this Nov 10, 2018
@treyadg treyadg reopened this Nov 10, 2018
@wdoekes wdoekes merged commit 55b18ee into SIPp:master Feb 26, 2019
@wdoekes
Copy link
Member

wdoekes commented Feb 26, 2019

Thanks! I'll add a return (ret >= 0 ? 0 : -1) for good measure.

wdoekes added a commit that referenced this pull request Feb 26, 2019
Fixed crash when exiting thread on sendto() failure
wdoekes pushed a commit that referenced this pull request Feb 26, 2019
(cherry-picked 6b11afc)
(cherry-picked a36c62b)

Closes #74
Closes #370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants