Remove lots of unnecessary RTPstream code and use [media_port] instead. #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
…port. This removes a chunk of unnecessary rtpstream code.
wdoekes
force-pushed
the
fix/rtpstream-source-port-192
branch
from
6e5ff95 to
3e327da
Compare
jeannotlanglois
added a commit
to jeannotlanglois/sipp
that referenced
this pull request
Aug 17, 2020
…les mistakenly removed by auto merge
jeannotlanglois
added a commit
to jeannotlanglois/sipp
that referenced
this pull request
Aug 23, 2020
- Validate presence of mandatory payload_name parameter in CAction::setRTPEchoActInfo() / CAction::setRTPStreamActInfo() - UAC side of RTPSTREAM must specify mandatory payload_name parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use multiple streams on a UAS which also uses a single port: then the RTP would all have the same 4-tuple and be a giant stream mess. But, if you can live with that, this cleans up the code quite nicely.
Closes #192.