Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect order of [routes] #262

Closed
smititelu opened this issue Oct 5, 2016 · 2 comments
Closed

incorrect order of [routes] #262

smititelu opened this issue Oct 5, 2016 · 2 comments

Comments

@smititelu
Copy link
Contributor

Hi,

I am starting SIPp as a UAS, with config file [1]. The problem I have, at BYE, is that [routes] append the "Route:" header with wrong content order, as below:

how it should look: Route:  <sip:172.16.38.75;lr=on;ftag=y96a53D52ZHXH>, <sip:172.16.38.63;lr;ftag=y96a53D52ZHXH>, <sip:172.16.38.53;lr=on;ftag=y96a53D52ZHXH>
how it looks: Route:  <sip:172.16.38.63;lr;ftag=y96a53D52ZHXH>, <sip:172.16.38.53;lr=on;ftag=y96a53D52ZHXH>,<sip:172.16.38.75;lr=on;ftag=y96a53D52ZHXH>

Should I do something in addition, or is this a bug?

[1] http://pastebin.com/fiFQKQK3

@wdoekes
Copy link
Member

wdoekes commented Oct 13, 2016

I haven't tested this, but I don't think this is necessarily a bug, but rather a "lack of feature".

If you'd run SIPp as an UAC, you want SIPp to put the Record-Route headers in reverse order into the [routes] set. I think SIPp has no idea whether it's UAS or UAC at that point and always simply stores them in reverse order.

The workaround for you would be to store the [Record-Route:] at incoming INVITE into a variable and use that instead of [routes].

@wdoekes
Copy link
Member

wdoekes commented Apr 9, 2017

Okay. It was a bug after all :)

I think this should fix things.

wdoekes added a commit that referenced this issue Feb 26, 2019
The strrchr-logic did not do what was intended at all.

Closes #262.

(cherry-picked b6c7b20 from master into branch/3.5)
(altered test scenario so it works when main IP is not 127.0.0.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants