Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next attribute not working with test attribute in first recv #103

Closed
kovacsbalu opened this issue Oct 2, 2014 · 4 comments
Closed

next attribute not working with test attribute in first recv #103

kovacsbalu opened this issue Oct 2, 2014 · 4 comments

Comments

@kovacsbalu
Copy link

Modify basic uas scenario with

<recv request="INVITE" next="200ok" test="var">
</recv>
<Reference variables="var" />

and put

<label id="200ok"/>

between 183 and 200.
UAS: sipp -i 127.0.0.1 -sf modified_uas.xml -m 1
UAC: sipp 127.0.0.1:5060 -sn uac -i 127.0.0.1 -m 1

Sipp should continue the scenario flow.
Sipp 3.4.1 also has this problem, works correctly with 3.2

This was useful for testing call queues when you feed var from csv file.
wdoekes referenced this issue Oct 3, 2014
@wdoekes
tests: Check SIPP env as full path to sipp binary for regression tests.
917be18 
Now you can do this to test a different sipp version:

    SIPP=/home/walter/src/sipp-3.2/sipp ./regress/runtests
    SIPP=/home/walter/src/sipp-3.2/sipp ./regress/github-#0103/run
wdoekes added a commit that referenced this issue Oct 3, 2014
@wdoekes
tests: Add github-#103 test for next-attribute-not-working-...
78380be 
Reported by: Kovács Bálint

Git bisect against this test says:

    $ git bisect bad
    302b2f8 is the first bad commit
    commit 302b2f8
    Author: Rob Day <[email protected]>
    Date:   Fri Feb 15 00:43:41 2013 +0000

        Fixing errors when compiling with -Wall -Wextra

        git-svn-id: svn://svn.code.sf.net/p/sipp/code/sipp/trunk@629 \
          60913f6b-29f6-41b8-8391-1ad2d2d6c344
wdoekes added a commit that referenced this issue Oct 3, 2014
@wdoekes
Reorder parentheses to fix issue with next attribute.
ce3ddf9 
The gcc -Wall warning about missing parentheses was fixed by adding
them around the wrong operators.  After this changeset, the next
parameter works like it should again.

Reported by: Kovács Bálint (@kovacsbalu)
Closes: github-#103.
@wdoekes
Copy link
Member

wdoekes commented Oct 3, 2014

Please try #105.

@kovacsbalu
Copy link
Author

Perfect, thank you!

@kovacsbalu
Copy link
Author

Sorry, there is a mistake in my bug report. Sipp should not jump to label, because var is not set.
Can you please fix my bug report in regression test xml?
"Sipp should continue the scenario flow."

wdoekes added a commit that referenced this issue Oct 3, 2014
@wdoekes
tests: Add github-#103 test for next-attribute-not-working-...
d917532 
Reported by: Kovács Bálint

Git bisect against this test says:

    $ git bisect bad
    302b2f8 is the first bad commit
    commit 302b2f8
    Author: Rob Day <[email protected]>
    Date:   Fri Feb 15 00:43:41 2013 +0000

        Fixing errors when compiling with -Wall -Wextra

        git-svn-id: svn://svn.code.sf.net/p/sipp/code/sipp/trunk@629 \
          60913f6b-29f6-41b8-8391-1ad2d2d6c344
wdoekes added a commit that referenced this issue Oct 3, 2014
@wdoekes
Reorder parentheses to fix issue with next attribute.
3a15d2f 
The gcc -Wall warning about missing parentheses was fixed by adding
them around the wrong operators.  After this changeset, the next
parameter works like it should again.

Reported by: Kovács Bálint (@kovacsbalu)
Closes: github-#103.
wdoekes added a commit that referenced this issue Oct 3, 2014
@wdoekes
Merge pull request #105 from SIPp/fix/next-attrib-fails-with-test-in-…
a211f34 
…recv

Fix for github-#103.
@wdoekes
Copy link
Member

wdoekes commented Oct 3, 2014

Thanks for testing.

@wdoekes wdoekes closed this as completed Oct 3, 2014
@jeannotlanglois jeannotlanglois mentioned this issue Aug 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wdoekes @kovacsbalu